content/common/browser_plugin_info.h - Issue 10735010: 3D Compositing in <browser>, first draft.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/browser_plugin_info.h

Issue 10735010: 3D Compositing in <browser>, first draft. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Major changes to clean up deadlock & other issues Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #ifndef HEADER_GUARD_THIS_FILE_DOT_H

	2 #define HEADER_GUARD_THIS_FILE_DOT_H
	scshunt 2012/08/12 01:42:45 Okay, this header file seems really bad, and shoul Okay, this header file seems really bad, and should be avoided if possible. Also the include guard is wrong. Note also that I forward-declare types declared here in number of files that use this header.
	3

	4 #include "base/basictypes.h"

	5

	6 struct BrowserPlugin_SwapInfo {

	7 int route_id;

	8 int gpu_host_id;

	9 };
	scshunt 2012/08/12 01:42:45 Can we avoid passing this to the embedder? Can we avoid passing this to the embedder?
	10

	11 struct BrowserPluginHostMsg_Surface_Params {

	12 int gpu_process_id;

	13 uint32 client_id;

	14 uint32 context_id;

	15 uint32 texture_id[2];

	16 uint32 sync_point;

	17 };

	18

	19 #endif

OLD	NEW