Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5088)

Unified Diff: chrome/common/instant_types.h

Issue 10732002: Upstream rewrite of Instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: First round of comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/instant_types.h
diff --git a/chrome/common/instant_types.h b/chrome/common/instant_types.h
index 46638f92b879eed307eddf7950f174b7638b51ed..f2dfc0aa38057060c581d33d328bcb55f8806bfd 100644
--- a/chrome/common/instant_types.h
+++ b/chrome/common/instant_types.h
@@ -5,15 +5,19 @@
#ifndef CHROME_COMMON_INSTANT_TYPES_H_
#define CHROME_COMMON_INSTANT_TYPES_H_
-// Enum describing the ways instant suggest text can be completed.
+#include <string>
+
+// Ways that the Instant suggested text is autocompleted into the omnibox.
enum InstantCompleteBehavior {
- // Complete the suggestion now.
+ // Autocomplete the suggestion immediately.
INSTANT_COMPLETE_NOW,
- // Complete the suggestion after a delay.
+ // Autocomplete the suggestion after a delay.
sky 2012/07/19 17:55:19 Its my understanding we're not using this, can it
Jered 2012/07/19 22:01:33 It's still referenced several places in the code,
sky 2012/07/19 23:44:40 I think it can be removed from all of them. But, t
Jered 2012/07/20 16:10:18 I will wait, then.
INSTANT_COMPLETE_DELAYED,
- // Never complete the suggestion.
+ // Do not autocomplete the suggestion. The suggestion may still be displayed
+ // in the omnibox, but not made a part of the omnibox text by default (e.g.,
+ // by displaying the suggestion as non-highlighted, non-selected gray text).
INSTANT_COMPLETE_NEVER
};

Powered by Google App Engine
This is Rietveld 408576698