Upstream rewrite of Instant.

chrome/browser/instant/instant_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/instant/instant_controller.h"
@@ skipping 24 matching lines @@
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_switches.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using content::WebContents;
 
 // Tests are flaky on Linux because of http://crbug.com/80118.
-#if defined(OS_LINUX) && !defined(USE_ASH)
-#define MAYBE(TestName) DISABLED_ ## TestName
-#elif defined(OS_WIN)
+#if defined(OS_WIN)
 #define MAYBE(TestName) FLAKY_ ## TestName
 #else
 #define MAYBE(TestName) TestName
 #endif
 
 class InstantTest : public InProcessBrowserTest {
  public:
-  InstantTest() {}
+  InstantTest() :
+    search_term_(ASCIIToUTF16("def")) {

[sky, 2012/07/25 17:29:56]

Either put search_term_ on the previous line, or wrap the ':' and fix the
indenting.

[jered1, 2012/07/25 20:22:04]

Done.

+  }
 
   void EnableInstant() {
     InstantController::Enable(browser()->profile());
   }
 
   void SetupInstantProvider(const std::string& page) {
     Profile* profile = browser()->profile();
     TemplateURLService* model =
         TemplateURLServiceFactory::GetForProfile(profile);
 
@@ skipping 11 matching lines @@
     data.SetURL(base::StringPrintf("http://%s:%d/files/%s?q={searchTerms}",
         test_server()->host_port_pair().host().c_str(),
         test_server()->host_port_pair().port(), page.c_str()));
     data.instant_url = data.url();
     // TemplateURLService takes ownership of this.
     TemplateURL* template_url = new TemplateURL(profile, data);
     model->Add(template_url);
     model->SetDefaultSearchProvider(template_url);
   }
 
+  void SetOmniboxFocusAndUserText(const string16& user_text) {
+    omnibox()->SetFocus();
+    omnibox()->SetUserText(user_text);
+  }
+
   // Type a character to get instant to trigger and determine instant support.
   void DetermineInstantSupport() {
     content::WindowedNotificationObserver observer(
         chrome::NOTIFICATION_INSTANT_SUPPORT_DETERMINED,
         content::NotificationService::AllSources());
     // "a" triggers the "about:" provider. "b" begins the "bing.com" keyword.
     // "c" might someday trigger a "chrome:" provider.
-    omnibox()->SetUserText(ASCIIToUTF16("d"));
+    SetOmniboxFocusAndUserText(ASCIIToUTF16("d"));
     observer.Wait();
   }
 
   // Types "def" into the omnibox and waits for the preview to be shown.
   void SearchAndWaitForPreviewToShow() {
     content::WindowedNotificationObserver observer(
         chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN,
         content::NotificationService::AllSources());
-    omnibox()->SetUserText(ASCIIToUTF16("def"));
+    SetOmniboxFocusAndUserText(search_term_);
     observer.Wait();
   }
 
   // Sends a message to the renderer and waits for the response to come back to
   // the browser. Returns true on success.
   bool WaitForMessageToBeProcessedByRenderer() {
     bool result = false;
     return GetBoolFromJavascript(preview()->web_contents(), "true", &result) &&
            result;
   }
 
   InstantController* instant() const {
     return browser()->instant_controller()->instant();
   }
 
   OmniboxView* omnibox() const {
     return browser()->window()->GetLocationBar()->GetLocationEntry();
   }
 
   TabContents* preview() const {
     return instant()->GetPreviewContents();
   }
 
   InstantLoader* loader() const {
     return instant()->loader_.get();
   }
 
-  std::string GetSuggestion() const {
-    return UTF16ToUTF8(loader()->complete_suggested_text_);
+  string16 last_full_text() const {

[sky, 2012/07/25 17:29:56]

const string16&

[jered1, 2012/07/25 20:22:04]

Done.

+    return instant()->last_full_text_;
+  }
+
+  bool is_showing() const {
+    return instant()->is_showing_;
   }
 
   bool PressEnter() {
     return ui_test_utils::SendKeyPressSync(
         browser(), ui::VKEY_RETURN, false, false, false, false);
   }
 
   bool SetSuggestionsJavascriptArgument(const std::string& argument) {
     std::wstring script = UTF8ToWide(base::StringPrintf(
         "window.setSuggestionsArgument = %s;", argument.c_str()));
@@ skipping 113 matching lines @@
                               selection_end);
   }
 
  protected:
   virtual void SetUpCommandLine(CommandLine* command_line) {
     // Do not prelaunch the GPU process for these tests because it will show
     // up in task manager but whether it appears before or after the new tab
     // renderer process is not well defined.
     command_line->AppendSwitch(switches::kDisableGpuProcessPrelaunch);
   }
+
+  const string16 search_term_;
 };
 
 // TODO(tonyg): Add the following tests:
 // - Test that the search box API is not populated for pages other than the
 //   default search provider.
 // - Test resize events.
 
 // Verify that the onchange event is dispatched upon typing in the box.
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(OnChangeEvent)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
   SearchAndWaitForPreviewToShow();
 
   EXPECT_TRUE(preview());
-  EXPECT_TRUE(instant()->is_displayable());
+  EXPECT_TRUE(is_showing());
   EXPECT_TRUE(instant()->IsCurrent());
-  EXPECT_EQ("defghi", UTF16ToUTF8(omnibox()->GetText()));
+  EXPECT_EQ(ASCIIToUTF16("defghi"), omnibox()->GetText());
 
   // Make sure the URL that will get committed when we press <Enter> matches
   // that of the default search provider.
   const TemplateURL* default_turl =
       TemplateURLServiceFactory::GetForProfile(browser()->profile())->
       GetDefaultSearchProvider();
   EXPECT_TRUE(default_turl);
   EXPECT_EQ(default_turl->url_ref().ReplaceSearchTerms(
-                TemplateURLRef::SearchTermsArgs(ASCIIToUTF16("defghi"))),
-            loader()->url().spec());
+                TemplateURLRef::SearchTermsArgs(string16())),
+            loader()->instant_url().spec());
 
   // Check that the value is reflected and onchange is called.
-  EXPECT_EQ("true 0 0 1 true d false def false 3 3",
+  EXPECT_EQ("true 0 0 2 false d false def true 3 3",
             GetSearchStateAsString(preview()->web_contents(), false));
 }
 
 // Verify that the onsubmit event is dispatched upon pressing <Enter>.
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(OnSubmitEvent)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
   SearchAndWaitForPreviewToShow();
 
   EXPECT_TRUE(preview());
-  EXPECT_TRUE(instant()->is_displayable());
+  EXPECT_TRUE(is_showing());
   EXPECT_TRUE(instant()->IsCurrent());
   EXPECT_EQ("defghi", UTF16ToUTF8(omnibox()->GetText()));
 
   WebContents* preview_tab = preview()->web_contents();
   EXPECT_TRUE(preview_tab);
 
   ASSERT_TRUE(PressEnter());
 
   // Check that the preview has been committed.
   EXPECT_FALSE(preview());
-  EXPECT_FALSE(instant()->is_displayable());
+  EXPECT_FALSE(is_showing());
   EXPECT_FALSE(instant()->IsCurrent());
   EXPECT_EQ(preview_tab, chrome::GetActiveWebContents(browser()));
 
   // We should have two entries. One corresponding to the page the user was
   // first on, and one for the search page.
   EXPECT_EQ(2, preview_tab->GetController().GetEntryCount());
 
   // Check that the value is reflected and onsubmit is called.
-  EXPECT_EQ("true 1 0 1 true d false defghi true 3 3",
+  EXPECT_EQ("true 1 0 2 false d false defghi true 6 6",
             GetSearchStateAsString(preview_tab, true));
 
   // Make sure the searchbox values were reset.
-  EXPECT_EQ("true 1 0 1 true d false  false 0 0",
+  EXPECT_EQ("true 1 0 2 false d false  false 0 0",
             GetSearchStateAsString(preview_tab, false));
 }
 
 // Verify that the oncancel event is dispatched upon losing focus.
 IN_PROC_BROWSER_TEST_F(InstantTest, DISABLED_OnCancelEvent) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
   SearchAndWaitForPreviewToShow();
 
   EXPECT_TRUE(preview());
-  EXPECT_TRUE(instant()->is_displayable());
+  EXPECT_TRUE(is_showing());
   EXPECT_TRUE(instant()->IsCurrent());
   EXPECT_EQ("defghi", UTF16ToUTF8(omnibox()->GetText()));
 
   WebContents* preview_tab = preview()->web_contents();
   EXPECT_TRUE(preview_tab);
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ui_test_utils::ClickOnView(browser(), VIEW_ID_TAB_CONTAINER);
 
   // Check that the preview has been committed.
   EXPECT_FALSE(preview());
-  EXPECT_FALSE(instant()->is_displayable());
+  EXPECT_FALSE(is_showing());
   EXPECT_FALSE(instant()->IsCurrent());
   EXPECT_EQ(preview_tab, chrome::GetActiveWebContents(browser()));
 
   // Check that the value is reflected and oncancel is called.
   EXPECT_EQ("true 0 1 1 true d false def false 3 3",
             GetSearchStateAsString(preview_tab, true));
 
   // Make sure the searchbox values were reset.
   EXPECT_EQ("true 0 1 1 true d false  false 0 0",
             GetSearchStateAsString(preview_tab, false));
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SetSuggestionsArrayOfStrings)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument("['defg', 'unused']"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("defg", GetSuggestion());
+  EXPECT_EQ(ASCIIToUTF16("defg"), last_full_text());
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SetSuggestionsEmptyArray)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument("[]"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("", GetSuggestion());
+  EXPECT_EQ(search_term_, last_full_text());
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SetSuggestionsValidJson)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument(
       "{suggestions:[{value:'defg'},{value:'unused'}]}"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("defg", GetSuggestion());
+  EXPECT_EQ(ASCIIToUTF16("defg"), last_full_text());
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SetSuggestionsInvalidSuggestions)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument("{suggestions:{value:'defg'}}"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("", GetSuggestion());
+  EXPECT_EQ(search_term_, last_full_text());
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SetSuggestionsEmptyJson)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument("{}"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("", GetSuggestion());
+  EXPECT_EQ(search_term_, last_full_text());
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SetSuggestionsEmptySuggestions)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument("{suggestions:[]}"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("", GetSuggestion());
+  EXPECT_EQ(search_term_, last_full_text());
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SetSuggestionsEmptySuggestion)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument("{suggestions:[{}]}"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("", GetSuggestion());
+  EXPECT_EQ(search_term_, last_full_text());
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(InstantCompleteNever)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument(
       "{suggestions:[{value:'defg'}],complete_behavior:'never'}"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("defg", GetSuggestion());
+  EXPECT_EQ(search_term_, last_full_text());
 
   EXPECT_EQ(INSTANT_COMPLETE_NEVER,
             omnibox()->model()->instant_complete_behavior());
-  EXPECT_EQ("def", UTF16ToUTF8(omnibox()->GetText()));
+  EXPECT_EQ(search_term_, omnibox()->GetText());
 }
 
-IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(InstantCompleteDelayed)) {
+IN_PROC_BROWSER_TEST_F(InstantTest, DISABLED_InstantCompleteDelayed) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument(
       "{suggestions:[{value:'defg'}],complete_behavior:'delayed'}"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("defg", GetSuggestion());
+  EXPECT_EQ(search_term_, last_full_text());
 
   EXPECT_EQ(INSTANT_COMPLETE_DELAYED,
             omnibox()->model()->instant_complete_behavior());
-  EXPECT_EQ("def", UTF16ToUTF8(omnibox()->GetText()));
+  EXPECT_EQ(ASCIIToUTF16("defg"), omnibox()->GetText());
 }
 
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(InstantCompleteNow)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
 
   ASSERT_TRUE(SetSuggestionsJavascriptArgument(
       "{suggestions:[{value:'defg'}],complete_behavior:'now'}"));
   SearchAndWaitForPreviewToShow();
-  EXPECT_EQ("defg", GetSuggestion());
+  EXPECT_EQ(ASCIIToUTF16("defg"), last_full_text());
 
   EXPECT_EQ(INSTANT_COMPLETE_NOW,
             omnibox()->model()->instant_complete_behavior());
-  EXPECT_EQ("defg", UTF16ToUTF8(omnibox()->GetText()));
+  EXPECT_EQ(ASCIIToUTF16("defg"), omnibox()->GetText());
 }
 
 // Verifies that instant previews aren't shown for crash URLs.
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(CrashUrlCancelsInstant)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
 
-  omnibox()->SetUserText(ASCIIToUTF16(chrome::kChromeUICrashURL));
+  SetOmniboxFocusAndUserText(ASCIIToUTF16(chrome::kChromeUICrashURL));
   EXPECT_FALSE(preview());
 }
 
 // Tests that instant doesn't fire for intranet paths that look like searches.
 // http://crbug.com/99836
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(IntranetPathLooksLikeSearch)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
 
@@ skipping 10 matching lines @@
   EXPECT_FALSE(preview());
 }
 
 // Verifies that instant previews aren't shown for non-search URLs.
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(ShowPreviewNonSearch)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
 
   GURL url(test_server()->GetURL("files/empty.html"));
-  omnibox()->SetUserText(UTF8ToUTF16(url.spec()));
+  SetOmniboxFocusAndUserText(UTF8ToUTF16(url.spec()));
   EXPECT_FALSE(preview());
 }
 
 // Transition from non-search to search and make sure everything works.
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(NonSearchToSearch)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
 
   // Load a non-search URL.
   GURL url(test_server()->GetURL("files/empty.html"));
-  omnibox()->SetUserText(UTF8ToUTF16(url.spec()));
+  SetOmniboxFocusAndUserText(UTF8ToUTF16(url.spec()));
   EXPECT_FALSE(preview());
 
   // Now type in some search text.
   DetermineInstantSupport();
 
   // We should now have a preview, but it shouldn't be showing yet, because we
   // haven't gotten back suggestions.
   EXPECT_TRUE(preview());
-  EXPECT_FALSE(loader()->ready());
-  EXPECT_FALSE(instant()->is_displayable());
-  EXPECT_FALSE(instant()->IsCurrent());
+  EXPECT_FALSE(is_showing());
+  EXPECT_TRUE(instant()->IsCurrent());
 
   // Reset the user text so that the page is told the text changed.
   //
   // Typing into the omnibox sends onchange() to the page, which responds with
   // suggestions, which causes the preview to be shown. However, when we called
   // DetermineInstantSupport(), the resulting onchange was dropped on the floor
   // because the page wasn't loaded yet. This is fine (the user may type before
   // the page loads too). To handle this, we explicitly call onchange after the
   // page loads (see initScript in searchbox_extension.cc). The search provider
   // used in this test (instant.html) doesn't support initScript, so we have to
   // trigger an onchange ourselves.
   SearchAndWaitForPreviewToShow();
 
   // We should now be showing the preview.
   EXPECT_TRUE(preview());
-  EXPECT_TRUE(loader()->ready());
-  EXPECT_TRUE(instant()->is_displayable());
+  EXPECT_TRUE(is_showing());
   EXPECT_TRUE(instant()->IsCurrent());
 
   content::RenderWidgetHostView* rwhv =
       preview()->web_contents()->GetRenderWidgetHostView();
   EXPECT_TRUE(rwhv);
   EXPECT_TRUE(rwhv->IsShowing());
 }
 
 // Transition from search to non-search and make sure instant isn't displayable.
 // See bug http://crbug.com/100368 for details.
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SearchToNonSearch)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
 
   content::WindowedNotificationObserver instant_support_observer(
       chrome::NOTIFICATION_INSTANT_SUPPORT_DETERMINED,
       content::NotificationService::AllSources());
 
   // Type in some search text.
-  omnibox()->SetUserText(ASCIIToUTF16("def"));
+  SetOmniboxFocusAndUserText(search_term_);
 
   // Load a non search URL. Don't wait for the preview to navigate. It'll still
   // end up loading in the background.
   GURL url(test_server()->GetURL("files/empty.html"));
-  omnibox()->SetUserText(UTF8ToUTF16(url.spec()));
+  SetOmniboxFocusAndUserText(UTF8ToUTF16(url.spec()));
 
   instant_support_observer.Wait();
 
   // We should now have a preview, but it shouldn't be showing yet.
   EXPECT_TRUE(preview());
-  EXPECT_FALSE(loader()->ready());
-  EXPECT_FALSE(instant()->is_displayable());
+  EXPECT_FALSE(is_showing());
   EXPECT_FALSE(instant()->IsCurrent());
 
   // Send onchange so that the page sends up suggestions. See the comments in
   // NonSearchToSearch for why this is needed.
   ASSERT_TRUE(ui_test_utils::ExecuteJavaScript(
       preview()->web_contents()->GetRenderViewHost(), std::wstring(),
       L"window.chrome.searchBox.onchange();"));
   ASSERT_TRUE(WaitForMessageToBeProcessedByRenderer());
 
   // Instant should be active, but not displaying.
   EXPECT_TRUE(preview());
-  EXPECT_TRUE(loader()->ready());
-  EXPECT_FALSE(instant()->is_displayable());
+  EXPECT_FALSE(is_showing());
   EXPECT_FALSE(instant()->IsCurrent());
 }
 
 // Makes sure that if the server doesn't support the instant API we don't show
 // anything.
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(SearchServerDoesntSupportInstant)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("empty.html");
 
   content::WindowedNotificationObserver tab_closed_observer(
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::NotificationService::AllSources());
 
-  omnibox()->SetUserText(ASCIIToUTF16("d"));
+  SetOmniboxFocusAndUserText(ASCIIToUTF16("d"));
   EXPECT_TRUE(preview());
 
   // When the response comes back that the page doesn't support instant the tab
   // should be closed.
   tab_closed_observer.Wait();
   EXPECT_FALSE(preview());
 }
 
 // Verifies transitioning from loading a non-search string to a search string
 // with the provider not supporting instant works (meaning we don't display
 // anything).
 IN_PROC_BROWSER_TEST_F(InstantTest,
                        MAYBE(NonSearchToSearchDoesntSupportInstant)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("empty.html");
 
   GURL url(test_server()->GetURL("files/empty.html"));
-  omnibox()->SetUserText(UTF8ToUTF16(url.spec()));
+  SetOmniboxFocusAndUserText(UTF8ToUTF16(url.spec()));
   EXPECT_FALSE(preview());
 
   content::WindowedNotificationObserver tab_closed_observer(
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::NotificationService::AllSources());
 
   // Now type in some search text.
-  omnibox()->SetUserText(ASCIIToUTF16("d"));
+  SetOmniboxFocusAndUserText(ASCIIToUTF16("d"));
   EXPECT_TRUE(preview());
 
   // When the response comes back that the page doesn't support instant the tab
   // should be closed.
   tab_closed_observer.Wait();
   EXPECT_FALSE(preview());
 }
 
 // Verifies the page was told a non-zero height.
-IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(ValidHeight)) {
+// TODO(dominich): This seems to be a dumb test. Confirm that it's dumb.
+IN_PROC_BROWSER_TEST_F(InstantTest, DISABLED_ValidHeight) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
   SearchAndWaitForPreviewToShow();
 
   int height = -1;
 
   // searchBox height is not yet set during initial load.
   ASSERT_TRUE(GetIntFromJavascript(preview()->web_contents(),
@@ skipping 23 matching lines @@
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(DontPersistSearchbox)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
   DetermineInstantSupport();
   SearchAndWaitForPreviewToShow();
 
   std::string value;
   ASSERT_TRUE(GetStringFromJavascript(preview()->web_contents(),
       "window.chrome.searchBox.value", &value));
-  EXPECT_EQ("def", value);
+  EXPECT_EQ(search_term_, UTF8ToUTF16(value));
 
   // Commit the preview.
   ASSERT_TRUE(PressEnter());
   EXPECT_FALSE(preview());
 
   // The searchBox actually gets cleared on commit.
   ASSERT_TRUE(GetStringFromJavascript(chrome::GetActiveWebContents(browser()),
       "window.chrome.searchBox.value", &value));
   EXPECT_EQ("", value);
 
@@ skipping 30 matching lines @@
 
   // Focusing the omnibox should cause instant to be preloaded.
   content::WindowedNotificationObserver instant_support_observer(
       chrome::NOTIFICATION_INSTANT_SUPPORT_DETERMINED,
       content::NotificationService::AllSources());
   browser()->window()->GetLocationBar()->FocusLocation(false);
   instant_support_observer.Wait();
 
   // Instant should have a preview, but not display it.
   EXPECT_TRUE(preview());
-  EXPECT_FALSE(instant()->is_displayable());
+  EXPECT_FALSE(is_showing());
   EXPECT_FALSE(instant()->IsCurrent());
   ASSERT_TRUE(CheckVisibilityIs(preview()->web_contents(), false));
 
   // Adding a new tab shouldn't delete (or recreate) the TabContents.
   TabContents* preview_tab = preview();
   AddBlankTabAndShow(browser());
   EXPECT_EQ(preview_tab, preview());
 
   // Doing a search should still use the same loader for the preview.
   SearchAndWaitForPreviewToShow();
   EXPECT_EQ(preview_tab, preview());
 
   // Verify that the preview is in fact showing instant search.
-  EXPECT_TRUE(instant()->is_displayable());
+  EXPECT_TRUE(is_showing());
   EXPECT_TRUE(instant()->IsCurrent());
   ASSERT_TRUE(CheckVisibilityIs(preview()->web_contents(), true));
 }
 
 // Tests that the instant search page's visibility is set correctly.
 IN_PROC_BROWSER_TEST_F(InstantTest, MAYBE(PageVisibilityTest)) {
   ASSERT_TRUE(test_server()->Start());
   EnableInstant();
   SetupInstantProvider("instant.html");
 
   // Initially navigate to the empty page which should be visible.
   ui_test_utils::NavigateToURL(browser(), test_server()->GetURL(""));
   WebContents* initial_contents = chrome::GetActiveWebContents(browser());
 
   ASSERT_TRUE(CheckVisibilityIs(initial_contents, true));
 
   // Type a search term and wait for the preview to appear.
   browser()->window()->GetLocationBar()->FocusLocation(false);
   DetermineInstantSupport();
   SearchAndWaitForPreviewToShow();
   WebContents* preview_contents = preview()->web_contents();
 
   ASSERT_TRUE(CheckVisibilityIs(preview_contents, true));
   ASSERT_TRUE(CheckVisibilityIs(initial_contents, false));
 
   // Deleting the user text should hide the preview.
-  omnibox()->SetUserText(string16());
+  SetOmniboxFocusAndUserText(string16());
   ASSERT_TRUE(CheckVisibilityIs(preview_contents, false));
   ASSERT_TRUE(CheckVisibilityIs(initial_contents, true));
 
   // Set the user text back and we should see the preview again.
-  omnibox()->SetUserText(ASCIIToUTF16("def"));
+  // TODO(dominich): This bit is not working. Copy-pasting allows us to see this
+  // in Chrome too.

[sky, 2012/07/25 17:29:56]

This comment doesn't make sense to me, but I'm assuming it does to dominch.

[jered1, 2012/07/25 20:22:04]

I've deleted the comment. Sreeram will just fix this in his patch.

+  SetOmniboxFocusAndUserText(ASCIIToUTF16("def"));
   ASSERT_TRUE(CheckVisibilityIs(preview_contents, true));
   ASSERT_TRUE(CheckVisibilityIs(initial_contents, false));
 
   // Commit the preview.
   ASSERT_TRUE(PressEnter());
   EXPECT_EQ(preview_contents, chrome::GetActiveWebContents(browser()));
   ASSERT_TRUE(CheckVisibilityIs(preview_contents, true));
 }
 
 // Tests that the task manager identifies instant's preview tab correctly.
@@ skipping 10 matching lines @@
   DetermineInstantSupport();
   SearchAndWaitForPreviewToShow();
 
   // Now there should be three rows, the third being the instant preview.
   TaskManagerBrowserTestUtil::WaitForResourceChange(3);
   string16 prefix = l10n_util::GetStringFUTF16(
       IDS_TASK_MANAGER_INSTANT_PREVIEW_PREFIX, string16());
   string16 title = task_manager->GetResourceTitle(2);
   EXPECT_TRUE(StartsWith(title, prefix, true)) << title << " vs " << prefix;
 }