Issue 10725: Fixes for Visual Studio solution + project file generation:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10725: Fixes for Visual Studio solution + project file generation:... (Closed)

Created:
12 years, 1 month ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes for Visual Studio solution + project file generation: * Fix the grit tool so it works with Repository() directories (and tap gspencer to upstream the changes). * Fix the evaluation of $PRE_EVALUATE_DIRS, which was interfering with sucking up the source files for listing in the .vcproj files. * Set AlwaysBuild() on the project files so they're always evaluated for up-to-dateness when 'all_solutions' is the target. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5440

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -4 lines)			Patch
M	build/SConscript.main	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	site_scons/site_tools/component_setup.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/grit/scons.py	View	2 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages