Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10719: Add GCController support to test_shell.... (Closed)

Created:
12 years, 1 month ago by Feng Qian
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add GCController support to test_shell. This is done in the binding layer, GCController is a JS object, GCController.collect() is a JS function which calls gc(). GCController object can be enabled by calling ScriptController::setShouldExposeGCController(true); GCController.collect() needs V8 expose gc function, which is controlled by a flag '--expose-gc'. Otherwise GCController.collect() has no effect. By default, test_shell exposes both gc function and GCController object. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M webkit/glue/webkit_glue.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/port/bindings/v8/ScriptController.h View 2 chunks +15 lines, -0 lines 0 comments Download
M webkit/port/bindings/v8/ScriptController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.cpp View 1 chunk +17 lines, -2 lines 1 comment Download
M webkit/tools/test_shell/node_leak_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Feng Qian
12 years, 1 month ago (2008-11-14 00:58:49 UTC) #1
Mike Belshe
lgtm http://codereview.chromium.org/10719/diff/1/3 File webkit/port/bindings/v8/v8_proxy.cpp (right): http://codereview.chromium.org/10719/diff/1/3#newcode1836 Line 1836: " function() {if (v8_gc) v8_gc(); };" Cool ...
12 years, 1 month ago (2008-11-14 01:11:54 UTC) #2
darin (slow to review)
12 years, 1 month ago (2008-11-14 01:34:17 UTC) #3
Clever.  Thanks, LGTM

Powered by Google App Engine
This is Rietveld 408576698