Issue 10716: Move dmg_fp to base/third_party/dmg_fp and include the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10716: Move dmg_fp to base/third_party/dmg_fp and include the (Closed)

Created:
12 years, 1 month ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move dmg_fp to base/third_party/dmg_fp and include the files directly in base.vcproj. Remove the old dmg_fp.vcproj file and remove it from the *.sln files. I've kept third_party/dmg_fp around for the mac and scons build which I will fix up in follow up changes.

Patch Set 1 #

Patch Set 2 : no filter #

Patch Set 3 : cleanup #

Patch Set 4 : tot #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3606 lines, -233 lines)			Patch
M	base/base.sln	View		4 chunks	+0 lines, -12 lines	0 comments	Download
M	base/build/base.vcproj	View	1	2 chunks	+44 lines, -0 lines	0 comments	Download
A	base/third_party/dmg_fp/README.google	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	base/third_party/dmg_fp/dmg_fp.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	base/third_party/dmg_fp/dtoa.cc	View		1 chunk	+3356 lines, -0 lines	0 comments	Download
A	base/third_party/dmg_fp/g_fmt.cc	View		1 chunk	+100 lines, -0 lines	0 comments	Download
M	chrome/chrome.sln	View	1 2 3	39 chunks	+35 lines, -17 lines	0 comments	Download
M	chrome/chrome_kjs.sln	View	1 2 3	36 chunks	+31 lines, -19 lines	0 comments	Download
M	net/net.sln	View	2	4 chunks	+0 lines, -12 lines	0 comments	Download
M	sandbox/sandbox.sln	View	1 2	3 chunks	+0 lines, -10 lines	0 comments	Download
M	third_party/dmg_fp/dmg_fp.vcproj	View		1 chunk	+0 lines, -139 lines	0 comments	Download
M	webkit/webkit.sln	View	1 2 3	4 chunks	+0 lines, -12 lines	0 comments	Download
M	webkit/webkit_kjs.sln	View	1 2 3	4 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

Dean's computer is at tech stop so he did an over the shoulder review. Patch ...

12 years, 1 month ago (2008-11-14 01:25:23 UTC) #3

ok

Expand Messages | Collapse Messages