Issue 10713: fix bug in locale dependence check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10713: fix bug in locale dependence check (Closed)

Created:
12 years, 1 month ago by tony

Modified:
9 years, 7 months ago

Reviewers:
please use my chromium address

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

fix bug in locale dependence check this caused us to always go down the language independent path

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/string_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

please use my chromium address

12 years, 1 month ago (2008-11-14 08:00:05 UTC) #2

Seems ok for me. If the difference between bool/LocaleDependence is misleading
(it may be), it could be a good idea to change all these bools to
LocaleDependence.

Expand Messages | Collapse Messages