Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6654)

Unified Diff: chrome/browser/ui/cocoa/content_settings/cookie_details.mm

Issue 10709006: Show apps protecting local data in chrome://settings/cookies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: argh Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/content_settings/cookie_details.mm
diff --git a/chrome/browser/ui/cocoa/content_settings/cookie_details.mm b/chrome/browser/ui/cocoa/content_settings/cookie_details.mm
index c36d084a28bd0358709cba80b07082082fd631b2..6483e1f65b0d5329878cb9eb0672cda36566e621 100644
--- a/chrome/browser/ui/cocoa/content_settings/cookie_details.mm
+++ b/chrome/browser/ui/cocoa/content_settings/cookie_details.mm
@@ -117,7 +117,6 @@
}
- (id)initWithCookie:(const net::CookieMonster::CanonicalCookie*)cookie
- origin:(NSString*)origin
canEditExpiration:(BOOL)canEditExpiration {
if ((self = [super init])) {
type_ = kCocoaCookieDetailsTypeCookie;
@@ -126,7 +125,7 @@
name_.reset([base::SysUTF8ToNSString(cookie->Name()) retain]);
content_.reset([base::SysUTF8ToNSString(cookie->Value()) retain]);
path_.reset([base::SysUTF8ToNSString(cookie->Path()) retain]);
- domain_.reset([origin retain]);
+ domain_.reset([base::SysUTF8ToNSString(cookie->Domain()) retain]);
if (cookie->IsPersistent()) {
expires_.reset([base::SysUTF16ToNSString(
@@ -258,12 +257,9 @@
+ (CocoaCookieDetails*)createFromCookieTreeNode:(CookieTreeNode*)treeNode {
CookieTreeNode::DetailedInfo info = treeNode->GetDetailedInfo();
CookieTreeNode::DetailedInfo::NodeType nodeType = info.node_type;
- NSString* origin;
switch (nodeType) {
case CookieTreeNode::DetailedInfo::TYPE_COOKIE:
- origin = base::SysUTF16ToNSString(info.origin.c_str());
return [[[CocoaCookieDetails alloc] initWithCookie:info.cookie
- origin:origin
canEditExpiration:NO] autorelease];
case CookieTreeNode::DetailedInfo::TYPE_DATABASE:
return [[[CocoaCookieDetails alloc]

Powered by Google App Engine
This is Rietveld 408576698