Show apps protecting local data in chrome://settings/cookies.

chrome/browser/ui/webui/cookies_tree_model_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/cookies_tree_model_util.h"
 
 #include <vector>
 
 #include "base/i18n/time_formatting.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_number_conversions.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/cookies_tree_model.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/text/bytes_formatting.h"
 
 namespace {
 
 const char kKeyId[] = "id";
 const char kKeyTitle[] = "title";
 const char kKeyIcon[] = "icon";
 const char kKeyType[] = "type";
 const char kKeyHasChildren[] = "hasChildren";
 
+const char kKeyProtectedByApps[] = "protectedByApps";

[Evan Stade, 2012/07/10 07:53:08]

these keys need documentation. And this key in particular needs a better name,
such as "appsThatProtect" or something, because "protectedByApps" apropos of
nothing is not very clear (sounds a lot like a boolean, or a list of apps that
this cookie "protects" somehow).

[Bernhard Bauer, 2012/07/10 09:50:59]

Done.

 const char kKeyName[] = "name";
 const char kKeyContent[] = "content";
 const char kKeyDomain[] = "domain";
 const char kKeyPath[] = "path";
 const char kKeySendFor[] = "sendfor";
 const char kKeyAccessibleToScript[] = "accessibleToScript";
 const char kKeyDesc[] = "desc";
 const char kKeySize[] = "size";
 const char kKeyOrigin[] = "origin";
 const char kKeyManifest[] = "manifest";
@@ skipping 47 matching lines @@
 
 bool CookiesTreeModelUtil::GetCookieTreeNodeDictionary(
     const CookieTreeNode& node,
     base::DictionaryValue* dict) {
   // Use node's address as an id for WebUI to look it up.
   dict->SetString(kKeyId, GetTreeNodeId(&node));
   dict->SetString(kKeyTitle, node.GetTitle());
   dict->SetBoolean(kKeyHasChildren, !node.empty());
 
   switch (node.GetDetailedInfo().node_type) {
-    case CookieTreeNode::DetailedInfo::TYPE_ORIGIN: {
+    case CookieTreeNode::DetailedInfo::TYPE_HOST: {
       dict->SetString(kKeyType, "origin");
 #if defined(OS_MACOSX)
       dict->SetString(kKeyIcon, "chrome://theme/IDR_BOOKMARK_BAR_FOLDER");
 #endif
       break;
     }
     case CookieTreeNode::DetailedInfo::TYPE_COOKIE: {
       dict->SetString(kKeyType, "cookie");
       dict->SetString(kKeyIcon, "chrome://theme/IDR_COOKIE_ICON");
 
@@ skipping 142 matching lines @@
       dict->SetString(kKeyExpires, UTF16ToUTF8(
           base::TimeFormatFriendlyDateAndTime(
               server_bound_cert.expiration_time())));
       break;
     }
     default:
 #if defined(OS_MACOSX)
       dict->SetString(kKeyIcon, "chrome://theme/IDR_BOOKMARK_BAR_FOLDER");
 #endif
       break;
   }

[Evan Stade, 2012/07/10 07:53:08]

\n

[Bernhard Bauer, 2012/07/10 09:50:59]

Done.

+  const ExtensionSet* protecting_apps =
+      node.GetModel()->ExtensionsProtectingNode(node);
+  if (protecting_apps && !protecting_apps->is_empty()) {
+    base::ListValue* app_infos = new base::ListValue;
+    for (ExtensionSet::const_iterator it =

[Evan Stade, 2012/07/10 07:53:08]

is this newline necessary?

[Bernhard Bauer, 2012/07/10 09:50:59]

No. Removed.

+             protecting_apps->begin();
+         it != protecting_apps->end(); ++it) {
+      base::DictionaryValue* app_info = new base::DictionaryValue();
+      app_info->SetString(kKeyId, (*it)->id());
+      app_info->SetString(kKeyName, (*it)->name());
+      app_infos->Append(app_info);
+    }
+    dict->Set(kKeyProtectedByApps, app_infos);
+  }

[Evan Stade, 2012/07/10 07:53:08]

\n

[Bernhard Bauer, 2012/07/10 09:50:59]

Done.

   return true;
 }
 
 void CookiesTreeModelUtil::GetChildNodeList(const CookieTreeNode* parent,
                                             int start,
                                             int count,
                                             base::ListValue* nodes) {
   for (int i = 0; i < count; ++i) {
     scoped_ptr<base::DictionaryValue> dict(new DictionaryValue);
     const CookieTreeNode* child = parent->GetChild(start + i);
@@ skipping 21 matching lines @@
     child = id_map_.Lookup(node_id);
     child_index = parent->GetIndexOf(child);
     if (child_index == -1)
       break;
 
     parent = child;
   }
 
   return child_index >= 0 ? child : NULL;
 }