Show apps protecting local data in chrome://settings/cookies.

chrome/browser/resources/options2/cookies_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
@@ skipping 204 matching lines @@
       this.itemsChild.style.height = itemsHeight + 'px';
       this.style.height = fixedHeight + 'px';
     },
 
     /**
      * Updates the origin summary to reflect changes in its items.
      * Both CookieListItem and CookieTreeNode implement this API.
      * This implementation scans the descendants to update the text.
      */
     updateOrigin: function() {
       var info = {

[Evan Stade, 2012/07/10 07:53:08]

surely the block of code between here and L271 deserves more vertical spacing
than it has (i.e. 0 blank lines)

[Bernhard Bauer, 2012/07/10 09:50:59]

Done.

         cookies: 0,
         database: false,
         localStorage: false,
         appCache: false,
         indexedDb: false,
         fileSystem: false,
         serverBoundCerts: 0,
       };
       if (this.origin)
         this.origin.collectSummaryInfo(info);
@@ skipping 12 matching lines @@
         list.push(loadTimeData.getString('cookie_file_system'));
       if (info.serverBoundCerts)
         list.push(loadTimeData.getString('cookie_server_bound_cert'));
       var text = '';
       for (var i = 0; i < list.length; ++i)
         if (text.length > 0)
           text += ', ' + list[i];
         else
           text = list[i];
       this.dataChild.textContent = text;
+      var apps = info.protectedByApps;
+      if (apps) {
+        for (var key in apps) {
+          var img = this.dataChild.ownerDocument.createElement('img');
+          img.src = 'chrome://extension-icon/' + key + '/16/1';
+          img.title = loadTimeData.getString('label_protected_by_apps') +

[Evan Stade, 2012/07/10 07:53:08]

perhaps this is part of the TODO to use a better app, but you shouldn't be
constructing strings by concatenation because that assumes all languages will be
of the form "$STRING $APPNAME", which is probably a false assumption.

[Bernhard Bauer, 2012/07/10 09:50:59]

Indeed! For this CL I'm just going with the existing string though (which is
"Set by:").

+                      ' ' + apps[key].name;
+          img.className = 'protecting-app';
+          this.dataChild.appendChild(img);
+        }
+      }
       if (info.quota && info.quota.totalUsage) {
         this.sizeChild.textContent = info.quota.totalUsage;
       }

[Evan Stade, 2012/07/10 07:53:08]

no curlies.

[Bernhard Bauer, 2012/07/10 09:50:59]

Done.

 
       if (this.expanded)
         this.updateItems_();
     },
 
     /**
      * Updates the items section to reflect changes, animating to the new state.
      * Removes existing contents and calls @{code CookieTreeNode.createItems}.
      * @private
      */
@@ skipping 177 matching lines @@
         } else if (this.data.type == 'app_cache') {
           info.appCache = true;
         } else if (this.data.type == 'indexed_db') {
           info.indexedDb = true;
         } else if (this.data.type == 'file_system') {
           info.fileSystem = true;
         } else if (this.data.type == 'quota') {
           info.quota = this.data;
         } else if (this.data.type == 'server_bound_cert') {
           info.serverBoundCerts++;
         }

[Evan Stade, 2012/07/10 07:53:08]

\n

[Bernhard Bauer, 2012/07/10 09:50:59]

Done.

+        var apps = this.data.protectedByApps;
+        if (apps) {
+          if (!info.protectedByApps)
+            info.protectedByApps = {};
+          apps.forEach(function(appInfo) {
+            info.protectedByApps[appInfo.id] = appInfo;
+          });
+        }
       }
     },
 
     /**
      * Create the cookie "bubbles" for this node, recursing into children
      * if there are any. Append the cookie bubbles to @{code item}.
      * @param {CookieListItem} item The cookie list item to create items in.
      */
     createItems: function(item) {
       if (this.children.length > 0) {

[Evan Stade, 2012/07/10 07:53:08]

ditto in this function, needs vertical spacing.

[Bernhard Bauer, 2012/07/10 09:50:59]

Done. I also flattened the nested if's a bit.

         for (var i = 0; i < this.children.length; ++i)
           this.children[i].createItems(item);
       } else if (this.data && !this.data.hasChildren) {
         var text = '';
         switch (this.data.type) {
           case 'cookie':
           case 'database':
             text = this.data.name;
             break;
           case 'local_storage':
@@ skipping 12 matching lines @@
             text = loadTimeData.getString('cookie_server_bound_cert');
             break;
         }
         if (!text)
           return;
         var div = item.ownerDocument.createElement('div');
         div.className = 'cookie-item';
         // Help out screen readers and such: this is a clickable thing.
         div.setAttribute('role', 'button');
         div.textContent = text;
+        var apps = this.data.protectedByApps;
+        if (apps) {
+          apps.forEach(function(appInfo) {

[Evan Stade, 2012/07/10 07:53:08]

hmm, this function looks oddly familiar

[Bernhard Bauer, 2012/07/10 09:50:59]

Extracted a function.

+            var img = div.ownerDocument.createElement('img');
+            img.src = 'chrome://extension-icon/' + appInfo.id + '/16/1';
+            img.title = loadTimeData.getString('label_protected_by_apps') +
+                        ' ' + appInfo.name;
+            img.className = 'protecting-app';
+            div.appendChild(img);
+          });
+        }
         var index = item.appendItem(this, div);
         div.onclick = function() {
           if (item.selectedIndex == index)
             item.selectedIndex = -1;
           else
             item.selectedIndex = index;
         };
       }
     },
 
     /**
      * Set the detail text to be displayed to that of this cookie tree node.
      * Uses preallocated DOM elements for each cookie node type from @{code
      * infoNodes}, and inserts the appropriate elements to @{code element}.
      * @param {Element} element The DOM element to insert elements to.
      * @param {Object.<string, {table: Element, info: Object.<string,
      *     Element>}>} infoNodes The map from cookie node types to maps from
      *     cookie attribute names to DOM elements to display cookie attribute
      *     values, created by @{code CookiesList.decorate}.
      */
     setDetailText: function(element, infoNodes) {
       var table;

[Evan Stade, 2012/07/10 07:53:08]

ditto in this function, needs vertical spacing.

[Bernhard Bauer, 2012/07/10 09:50:59]

Done.

       if (this.data && !this.data.hasChildren) {
         if (cookieInfo[this.data.type]) {
           var info = cookieInfo[this.data.type];
           var nodes = infoNodes[this.data.type].info;
           for (var i = 0; i < info.length; ++i) {
             var name = info[i][0];
             if (name != 'id' && this.data[name])
               nodes[name].textContent = this.data[name];
             else
               nodes[name].textContent = '';
@@ skipping 11 matching lines @@
      * The parent of this cookie tree node.
      * @type {?CookieTreeNode|CookieListItem}
      */
     get parent() {
       // See below for an explanation of this special case.
       if (typeof this.parent_ == 'number')
         return this.list_.getListItemByIndex(this.parent_);
       return this.parent_;
     },
     set parent(parent) {
       if (parent == this.parent)

[Evan Stade, 2012/07/10 07:53:08]

ditto in this function, needs vertical spacing.

[Bernhard Bauer, 2012/07/10 09:50:59]

Done.

         return;
       if (parent instanceof CookieListItem) {
         // If the parent is to be a CookieListItem, then we keep the reference
         // to it by its containing list and list index, rather than directly.
         // This allows the list items to be garbage collected when they scroll
         // out of view (except the expanded item, which we cache). This is
         // transparent except in the setter and getter, where we handle it.
         this.parent_ = parent.listIndex;
         this.list_ = parent.list;
         parent.addEventListener('listIndexChange',
@@ skipping 289 matching lines @@
       parent.clear();
       this.addByParent_(parent, 0, children);
       parent.endBatchUpdates();
     },
   };
 
   return {
     CookiesList: CookiesList
   };
 });