chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js - Issue 10704258: Add extension permissions for Media Gallery API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js

Issue 10704258: Add extension permissions for Media Gallery API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove the permissions that aren't ready yet Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/permission_set.cc ('k') | chrome/test/data/extensions/api_test/media_galleries/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js b/chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js

index 86e280da02b2b7e2c65a803a4507273ed99a15f0..720ca62ba5557a46d46baf34cb32acf94561fbbc 100644

--- a/chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js

@@ -16,11 +16,13 @@ chromeHidden.registerCustomHook('experimental.mediaGalleries',

// return an array of file system objects.

apiFunctions.setCustomCallback('getMediaFileSystems',

function(name, request, response) {

- var result = [];

- for (var i = 0; i < response.length; i++) {

- result.push(

- mediaGalleriesNatives.GetMediaFileSystemObject(response[i].fsid,

- response[i].dirname));

+ var result = null;

+ if (response != undefined) {

Evan Stade 2012/07/23 23:51:06 I think if (response) is fine. If you have to chec

vandebo (ex-Chrome) 2012/07/24 00:00:38 Done.

+ result = [];

+ for (var i = 0; i < response.length; i++) {

+ result.push(mediaGalleriesNatives.GetMediaFileSystemObject(

+ response[i].fsid, response[i].dirname));

+ }

}

if (request.callback)

request.callback(result);