Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 10704258: Add extension permissions for Media Gallery API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments and fix unit test Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_file_value_serializer.h" 6 #include "base/json/json_file_value_serializer.h"
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 571
572 572
573 // This permission requires explicit user action (context menu handler) 573 // This permission requires explicit user action (context menu handler)
574 // so we won't prompt for it for now. 574 // so we won't prompt for it for now.
575 skip.insert(APIPermission::kFileBrowserHandler); 575 skip.insert(APIPermission::kFileBrowserHandler);
576 576
577 // This permission requires explicit user action (shortcut) so we don't 577 // This permission requires explicit user action (shortcut) so we don't
578 // prompt for it. 578 // prompt for it.
579 skip.insert(APIPermission::kKeybinding); 579 skip.insert(APIPermission::kKeybinding);
580 580
581 // These permissions require explicit user action (configuration dialog)
582 // so we don't prompt for them at install time.
583 skip.insert(APIPermission::kMediaGalleries);
584 skip.insert(APIPermission::kMediaGalleriesRead);
585
581 // If you've turned on the experimental command-line flag, we don't need 586 // If you've turned on the experimental command-line flag, we don't need
582 // to warn you further. 587 // to warn you further.
583 skip.insert(APIPermission::kExperimental); 588 skip.insert(APIPermission::kExperimental);
584 589
585 // These are private. 590 // These are private.
586 skip.insert(APIPermission::kChromeAuthPrivate); 591 skip.insert(APIPermission::kChromeAuthPrivate);
587 skip.insert(APIPermission::kChromeosInfoPrivate); 592 skip.insert(APIPermission::kChromeosInfoPrivate);
588 skip.insert(APIPermission::kFileBrowserHandlerInternal); 593 skip.insert(APIPermission::kFileBrowserHandlerInternal);
589 skip.insert(APIPermission::kFileBrowserPrivate); 594 skip.insert(APIPermission::kFileBrowserPrivate);
590 skip.insert(APIPermission::kInputMethodPrivate); 595 skip.insert(APIPermission::kInputMethodPrivate);
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 apis.insert(APIPermission::kWebRequest); 1134 apis.insert(APIPermission::kWebRequest);
1130 apis.insert(APIPermission::kFileBrowserHandler); 1135 apis.insert(APIPermission::kFileBrowserHandler);
1131 EXPECT_EQ(2U, apis.size()); 1136 EXPECT_EQ(2U, apis.size());
1132 1137
1133 scoped_refptr<PermissionSet> perm_set; 1138 scoped_refptr<PermissionSet> perm_set;
1134 perm_set = new PermissionSet(apis, empty_extent, empty_extent); 1139 perm_set = new PermissionSet(apis, empty_extent, empty_extent);
1135 EXPECT_EQ(4U, perm_set->apis().size()); 1140 EXPECT_EQ(4U, perm_set->apis().size());
1136 } 1141 }
1137 1142
1138 } // namespace extensions 1143 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698