Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5049)

Unified Diff: chrome/common/extensions/docs/server2/example_zipper.py

Issue 10704252: Extensions Docs Server: Internal file system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed up Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/example_zipper.py
diff --git a/chrome/common/extensions/docs/server2/example_zipper.py b/chrome/common/extensions/docs/server2/example_zipper.py
index 7d7fef75559568a14016a2b6b47b51b2293d9cea..a21867cfd3ecfab9b3442798f2441aaaa9635fe9 100644
--- a/chrome/common/extensions/docs/server2/example_zipper.py
+++ b/chrome/common/extensions/docs/server2/example_zipper.py
@@ -10,10 +10,10 @@ from zipfile import ZipFile
class ExampleZipper(object):
"""This class creates a zip file given a samples directory.
"""
- def __init__(self, fetcher, cache_builder, base_path, match_path):
+ def __init__(self, file_system, cache_builder, base_path, match_path):
self._base_path = base_path
self._zip_cache = cache_builder.build(self._MakeZipFile)
- self._fetcher = fetcher
+ self._file_system = file_system
self._match_path = match_path
def _MakeZipFile(self, files):
@@ -24,18 +24,16 @@ class ExampleZipper(object):
zip_bytes = BytesIO()
zip_file = ZipFile(zip_bytes, mode='w')
try:
- for filename in files:
- zip_file.writestr(
- filename[len(prefix):].strip('/'),
- self._fetcher.FetchResource(filename).content)
+ for filename, contents in self._file_system.Read(files).Get().iteritems():
+ zip_file.writestr(filename[len(prefix):].strip('/'), contents)
finally:
zip_file.close()
return zip_bytes.getvalue()
- def create(self, path):
+ def Create(self, path):
""" Creates a new zip file from the recursive contents of |path|
as returned by |_zip_cache|.
Paths within the zip file are given relative to and including |path|.
"""
- return self._zip_cache.getFromFileListing(self._base_path + '/' + path,
- recursive=True)
+ return self._zip_cache.GetFromFileListing(
+ self._base_path + '/' + path)
« no previous file with comments | « chrome/common/extensions/docs/server2/echo_handler.py ('k') | chrome/common/extensions/docs/server2/fake_url_fetcher.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698