Extensions Docs Server: Internal file system

chrome/common/extensions/docs/server2/lazy_value.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+_no_value = object()
+
+class LazyValue(object):

[not at google - send to devlin, 2012/07/18 10:39:15]

I realised today that this isn't *like* Java's Future. It *is* Java's Future.

So... call it Future. Sorry bout that :)

also: documentation

[cduvall, 2012/07/18 21:26:10]

Done.

+  def __init__(self, value=_no_value, error=None, delegate=None):
+    self._value = value
+    self._error = error
+    self._delegate = delegate
+    if (self._value is _no_value and
+        self._error is None and
+        self._delegate is None):

[not at google - send to devlin, 2012/07/18 10:39:15]

what's wrong with ==

[cduvall, 2012/07/18 21:26:10]

See previous comment.

+      raise ValueError('Must have either a value, error, or delegate.')
+
+  def Get(self):

[not at google - send to devlin, 2012/07/18 10:39:15]

documentation

[cduvall, 2012/07/18 21:26:10]

Done.

+    if self._value is not _no_value:
+      return self._value
+    if self._error is not None:

[not at google - send to devlin, 2012/07/18 10:39:15]

what's wrong with !=

[cduvall, 2012/07/18 21:26:10]

See previous comment.

+      raise self._error
+    try:
+      self._value = self._delegate.Get()
+    except Exception as self._error:
+      raise
+    return self._value