Extensions Docs Server: Internal file system

chrome/common/extensions/docs/server2/branch_utility.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 
 OMAHA_PROXY_URL = 'http://omahaproxy.appspot.com/json'
 
 def SplitChannelNameFromPath(path, default='stable'):
   try:
     first, second = path.split('/', 1)
   except ValueError:
     first = path
-    second =''
+    second = ''
   if first in ['trunk', 'dev', 'beta', 'stable']:
     return (first, second)
   else:
     return (default, path)
 
 def GetBranchNumberForChannelName(channel_name,
                                   urlfetch,
                                   base_path=OMAHA_PROXY_URL):
   """Returns an empty string if the branch number cannot be found.
   Throws exception on network errors.
   """
   if channel_name == 'trunk' or channel_name == 'local':
     return channel_name

[not at google - send to devlin, 2012/07/18 10:39:15]

I posit that this isn't a number

(just sayin)

[cduvall, 2012/07/18 21:26:10]

It could be something like "1180_38" which isn't really a number either.

 
   fetch_data = urlfetch.fetch(base_path)

[not at google - send to devlin, 2012/07/18 10:39:15]

The result of this fetch should be cached. Just memcache it for an hour or so.

Though that'd mean you need to abstract away memcache for testing. Bleh. Maybe
you'll need to do that anyway to test memcache_file_system.

Btw please make this a class, injecting urlfetch into every call to
GetBranchNumberForChannelName is icky. Ditto base_path.

[cduvall, 2012/07/18 21:26:10]

Done.

   if fetch_data.content == '':
     raise Exception('Fetch returned zero results.')

[not at google - send to devlin, 2012/07/18 10:39:15]

It'd crash anyway with an invalid JSON thing, so checking here is kinda moot. I
don't see why empty is any different to invalid json.

[cduvall, 2012/07/18 21:26:10]

Done.

 
   version_json = json.loads(fetch_data.content)
   branch_numbers = {}
   for entry in version_json:
     if entry['os'] not in ['win', 'linux', 'mac', 'cros']:
       continue
     for version in entry['versions']:
       if version['channel'] != channel_name:
         continue
       if version['true_branch'] not in branch_numbers:
         branch_numbers[version['true_branch']] = 0
       else:
         branch_numbers[version['true_branch']] += 1
 
   sorted_list = [x for x in branch_numbers.iteritems()]

[not at google - send to devlin, 2012/07/18 10:39:15]

x for x in blah... isn't that just blah?

If you're trying to listify, then list(branch_numbers.iteritems()) would do it.
then again, for that matter, so would branch_numbers.items().

then again, this whole expression can just be:
sorted_list = sorted(branch_numbers.iteritems(),
                     key=operator.itemgetter(1),
                     reversed=True)

also sorted_list is pretty vague, sorted_branches or something. whatever it's
supposed to be.

[cduvall, 2012/07/18 21:26:10]

Wow this was ugly. I haven't looked at it since I started working on the docs
server.

   sorted_list.sort(key = lambda x: x[1])

[not at google - send to devlin, 2012/07/18 10:39:15]

key=itemgetter(1)

[cduvall, 2012/07/18 21:26:10]

Done.

   sorted_list.reverse()
 
   branch_number, _ = sorted_list[0]
 
   return branch_number