chrome/common/extensions/docs/server2/appengine_url_fetcher.py - Issue 10704252: Extensions Docs Server: Internal file system

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/server2/appengine_url_fetcher.py

Issue 10704252: Extensions Docs Server: Internal file system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Tests Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/docs/server2/api_data_source_test.py ('K') | « chrome/common/extensions/docs/server2/app.yaml ('k') | chrome/common/extensions/docs/server2/async_fetch_value.py » ('j') | chrome/common/extensions/docs/server2/async_fetch_value.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from google.appengine.api import urlfetch

	6

	7 class AppEngineUrlFetcher(object):
	not at google - send to devlin 2012/07/18 10:39:15 documentation documentation cduvall 2012/07/18 21:26:10 Done. Show quoted text On 2012/07/18 10:39:15, kalman wrote: > documentation Done.
	8 def __init__(self, base_path):

	9 self._base_path = base_path

	10

	11 def fetch(self, url):
	not at google - send to devlin 2012/07/18 10:39:15 These should all be Google-style, like Fetch. These should all be Google-style, like Fetch. cduvall 2012/07/18 21:26:10 Done. Show quoted text On 2012/07/18 10:39:15, kalman wrote: > These should all be Google-style, like Fetch. Done.
	12 return urlfetch.fetch(self._base_path + '/' + url)

	13

	14 def create_rpc(self):

	15 return urlfetch.create_rpc()

	16

	17 def make_fetch_call(self, rpc, path):
	not at google - send to devlin 2012/07/18 10:39:15 This is the appengine API, I know; but it could This is the appengine API, I know; but it could be done a higher level (particularly if we're going to make fake ones). It's just that this create_rpc/make_fetch_call yuck is a pain to fake out. Coud you have it be like, Fetch (calls .fetch directly) and FetchAsync (returns a Future for a fetch value and does the create_rpc stuff itself). cduvall 2012/07/18 21:26:10 Done. Show quoted text On 2012/07/18 10:39:15, kalman wrote: > This is the appengine API, I know; but it could be done a higher level > (particularly if we're going to make fake ones). It's just that this > create_rpc/make_fetch_call yuck is a pain to fake out. > > Coud you have it be like, Fetch (calls .fetch directly) and FetchAsync (returns > a Future for a fetch value and does the create_rpc stuff itself). Done.
	18 return urlfetch.make_fetch_call(rpc, self._base_path + '/' + path)

OLD	NEW