Change DeterministicMockTCPClientSocket to set the peer address from the connect data.

Change DeterministicMockTCPClientSocket to set the peer address from the connect data.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146238

[Ryan Sleevi, 2012-07-11 21:34:14]

lgtm

http://codereview.chromium.org/10704166/diff/1/net/socket/socket_test_util.cc
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/10704166/diff/1/net/socket/socket_test_util.cc...
net/socket/socket_test_util.cc:946: peer_addr_ = data->connect_data().peer_addr;
protected members make me sad. Took me much too long to find:

1) DeterministicMockTCPClientSocket is-a MockClientSocket (due to the newline
wrapping in the .h that puts AsyncSocket on the new line, rather than the
MockClientSocket - line 683)
2) Where this member was actually defined.

Could you also fix #1 with this change? (and MockUDPClientSocket at line 789 of
the .h)

[Ryan Hamilton, 2012-07-11 21:51:13]

http://codereview.chromium.org/10704166/diff/1/net/socket/socket_test_util.cc
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/10704166/diff/1/net/socket/socket_test_util.cc...
net/socket/socket_test_util.cc:946: peer_addr_ = data->connect_data().peer_addr;
On 2012/07/11 21:34:14, Ryan Sleevi wrote:
> protected members make me sad. Took me much too long to find:
> 
> 1) DeterministicMockTCPClientSocket is-a MockClientSocket (due to the newline
> wrapping in the .h that puts AsyncSocket on the new line, rather than the
> MockClientSocket - line 683)
> 2) Where this member was actually defined.
> 
> Could you also fix #1 with this change? (and MockUDPClientSocket at line 789
of
> the .h)

Done, I think.  Would you mind taking a look to confirm?

[Ryan Sleevi, 2012-07-11 21:54:57]

lgtm

[commit-bot: I haz the power, 2012-07-11 21:55:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/10704166/5001

[commit-bot: I haz the power, 2012-07-11 23:35:07]

Change committed as 146238