Use isfinite instead of finite on Mac

base/float_util.h

Index: base/float_util.h
diff --git a/base/float_util.h b/base/float_util.h
index 69334d09bf1749d10b4c53bb7a03ecd4f54ae92c..2a03023726012c492c4e8613dd7775fc119edbab 100644
--- a/base/float_util.h
+++ b/base/float_util.h
@@ -18,7 +18,11 @@
 namespace base {
 
 inline bool IsFinite(const double& number) {
-#if defined(OS_POSIX)
+#if defined(OS_MACOSX)
+  // C99 says isfinite() replaced finite(), and iOS does not provide the
+  // older call.
+  return isfinite(number) != 0;
+#elif defined(OS_POSIX)
   return finite(number) != 0;

[Mark Mentovai, 2012/07/10 12:19:29]

If you’re afraid to change this, and I’m not, but IF you are…

Another alternative is

#if defined(OS_POSIX)
#include <cmath>
#endif

inline bool IsFinite(const double& number) {
#if defined(OS_POSIX)
  return std::isfinite(number) != 0;
#endif
}

and then I think you can drop <ieeefp.h> too.

 #elif defined(OS_WIN)
   return _finite(number) != 0;