chrome/browser/extensions/crx_installer_browsertest.cc - Issue 10704052: Download filename determination refactor (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 10704052: Download filename determination refactor (3/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with r148594 to and resolve conflicts with r148576 Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/crx_installer_browsertest.cc

diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc

index 550c2dc6329c79a078ea266e2bfca9192266b8e7..fba4c478103cf6a887f3d339f15ad85f8005677b 100644

--- a/chrome/browser/extensions/crx_installer_browsertest.cc

+++ b/chrome/browser/extensions/crx_installer_browsertest.cc

@@ -192,7 +192,6 @@ IN_PROC_BROWSER_TEST_F(

return;

const int kNumDownloadsExpected = 1;

- const bool kExpectFileSelectDialog = false;

LOG(ERROR) << "PackAndInstallExtension: Packing extension";

FilePath crx_path = PackExtension(

@@ -212,7 +211,7 @@ IN_PROC_BROWSER_TEST_F(

LOG(ERROR) << "PackAndInstallExtension: Setting observer";

scoped_ptr<DownloadTestObserver> observer(

new DownloadTestObserverTerminal(

- download_manager, kNumDownloadsExpected, kExpectFileSelectDialog,

+ download_manager, kNumDownloadsExpected,

DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_ACCEPT));

LOG(ERROR) << "PackAndInstallExtension: Navigating to URL";

ui_test_utils::NavigateToURLWithDisposition(browser(), url, CURRENT_TAB,