Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: content/public/browser/download_item.h

Issue 10704052: Download filename determination refactor (3/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_item.h
diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h
index f1f420bc87481197d5a03a3bdb08d7328e3a02fa..09c5d21ed63af2333c46ec0733f7c68173057749 100644
--- a/content/public/browser/download_item.h
+++ b/content/public/browser/download_item.h
@@ -27,7 +27,6 @@
#include "content/public/browser/download_interrupt_reasons.h"
#include "content/public/common/page_transition_types.h"
-class DownloadFileManager;
class FilePath;
class GURL;
struct DownloadCreateInfo;
@@ -221,31 +220,11 @@ class CONTENT_EXPORT DownloadItem {
// Get the target disposition.
virtual TargetDisposition GetTargetDisposition() const = 0;
- // Called when the target path has been determined. |target_path| is the
- // suggested target path. |disposition| indicates how the target path should
- // be used (see TargetDisposition). |danger_type| is the danger level of
- // |target_path| as determined by the caller. If |disposition| is
- // TARGET_DISPOSITION_PROMPT, then OnTargetPathSelected() should be called
- // subsequently with the user's selected target path.
- virtual void OnTargetPathDetermined(
- const FilePath& target_path,
- TargetDisposition disposition,
- content::DownloadDangerType danger_type) = 0;
-
- // This method should be called if and only if OnTargetPathDetermined() was
- // called previously with disposition set to TARGET_DISPOSITION_PROMPT.
- // |target_path| is the path that the user selected after being prompted for a
- // target path.
- virtual void OnTargetPathSelected(const FilePath& target_path) = 0;
-
// Called if a check of the download contents was performed and the results of
// the test are available. This should only be called after AllDataSaved() is
// true.
virtual void OnContentCheckCompleted(DownloadDangerType danger_type) = 0;
- virtual void OnIntermediatePathDetermined(DownloadFileManager* file_manager,
- const FilePath& path) = 0;
-
virtual bool IsPersisted() const = 0;
// Accessors

Powered by Google App Engine
This is Rietveld 408576698