Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4928)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 10704052: Download filename determination refactor (3/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/download/download_service.cc ('K') | « chrome/browser/extensions/api/downloads/downloads_api_unittest.cc ('k') | chrome/browser/profiles/off_the_record_profile_impl.cc » ('j') | content/public/browser/download_manager_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index f4f243c8f98679a903093abd051cf9ac5143132b..650c88c5b1640b2e8b48870219aad40dd205e7ab 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -193,7 +193,6 @@ IN_PROC_BROWSER_TEST_F(
return;
const int kNumDownloadsExpected = 1;
- const bool kExpectFileSelectDialog = false;
LOG(ERROR) << "PackAndInstallExtension: Packing extension";
FilePath crx_path = PackExtension(
@@ -213,7 +212,7 @@ IN_PROC_BROWSER_TEST_F(
LOG(ERROR) << "PackAndInstallExtension: Setting observer";
scoped_ptr<DownloadTestObserver> observer(
new DownloadTestObserverTerminal(
- download_manager, kNumDownloadsExpected, kExpectFileSelectDialog,
+ download_manager, kNumDownloadsExpected,
DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_ACCEPT));
LOG(ERROR) << "PackAndInstallExtension: Navigating to URL";
ui_test_utils::NavigateToURLWithDisposition(browser(), url, CURRENT_TAB,
« chrome/browser/download/download_service.cc ('K') | « chrome/browser/extensions/api/downloads/downloads_api_unittest.cc ('k') | chrome/browser/profiles/off_the_record_profile_impl.cc » ('j') | content/public/browser/download_manager_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698