Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: content/browser/download/download_item_impl_unittest.cc

Issue 10704052: Download filename determination refactor (3/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use a callback with DetermineDownloadTarget(). Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl_unittest.cc
diff --git a/content/browser/download/download_item_impl_unittest.cc b/content/browser/download/download_item_impl_unittest.cc
index c7ac84d9f618cf407726ab2ca82508d042f2629e..1bfb099b61c88acbec731d286e56690cfb04a92e 100644
--- a/content/browser/download/download_item_impl_unittest.cc
+++ b/content/browser/download/download_item_impl_unittest.cc
@@ -313,17 +313,6 @@ TEST_F(DownloadItemTest, NotificationAfterOnTargetPathDetermined) {
EXPECT_TRUE(dangerous_observer.CheckUpdated());
}
-TEST_F(DownloadItemTest, NotificationAfterOnTargetPathSelected) {
- DownloadItem* item = CreateDownloadItem(DownloadItem::IN_PROGRESS);
- MockObserver observer(item);
-
- item->OnTargetPathDetermined(
- FilePath(kDummyPath), DownloadItem::TARGET_DISPOSITION_PROMPT,
- content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS);
- item->OnTargetPathSelected(FilePath(kDummyPath));
- EXPECT_FALSE(observer.CheckUpdated());
-}
-
TEST_F(DownloadItemTest, NotificationAfterOnContentCheckCompleted) {
// Setting to NOT_DANGEROUS does not trigger a notification.
DownloadItem* safe_item = CreateDownloadItem(DownloadItem::IN_PROGRESS);

Powered by Google App Engine
This is Rietveld 408576698