Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: content/browser/download/download_item_impl.h

Issue 10704052: Download filename determination refactor (3/3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use a callback with DetermineDownloadTarget(). Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index 96346e9846ccf6a6521994f98156c067b0662e10..ed42f4bb3fef3f5853cae52abf6cdcec83f8f03a 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -62,6 +62,9 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {
// For contextual issues like language and prefs.
virtual content::BrowserContext* GetBrowserContext() const = 0;
+ // Get the DownloadFileManager to use for this download.
+ virtual DownloadFileManager* GetDownloadFileManager() = 0;
+
// Handle any delegate portions of a state change operation on the
// DownloadItem.
virtual void DownloadStopped(DownloadItem* download) = 0;
@@ -151,15 +154,13 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {
virtual const FilePath& GetFullPath() const OVERRIDE;
virtual const FilePath& GetTargetFilePath() const OVERRIDE;
virtual TargetDisposition GetTargetDisposition() const OVERRIDE;
- virtual void OnTargetPathDetermined(
+ virtual void OnDownloadTargetDetermined(
const FilePath& target_path,
TargetDisposition disposition,
- content::DownloadDangerType danger_type) OVERRIDE;
- virtual void OnTargetPathSelected(const FilePath& target_path) OVERRIDE;
+ content::DownloadDangerType danger_type,
+ const FilePath& intermediate_path) OVERRIDE;
virtual void OnContentCheckCompleted(
content::DownloadDangerType danger_type) OVERRIDE;
- virtual void OnIntermediatePathDetermined(DownloadFileManager* file_manager,
- const FilePath& path) OVERRIDE;
virtual const GURL& GetURL() const OVERRIDE;
virtual const std::vector<GURL>& GetUrlChain() const OVERRIDE;
virtual const GURL& GetOriginalUrl() const OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698