Download filename determination refactor (3/3)

chrome/browser/browsing_data_remover.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data_remover.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 276 matching lines @@
         session_service->DeleteLastSession();
 #endif
     }
   }
 
   if (remove_mask & REMOVE_DOWNLOADS) {
     content::RecordAction(UserMetricsAction("ClearBrowsingData_Downloads"));
     DownloadManager* download_manager =
         BrowserContext::GetDownloadManager(profile_);
     download_manager->RemoveDownloadsBetween(delete_begin_, delete_end_);
-    download_manager->ClearLastDownloadPath();
+    download_manager->ClearTransientState();

[Randy Smith (Not in Mondays), 2012/07/05 15:42:32]

Given that this is in chrome, could it get the CDMD and call the function on
that directly, thus avoiding the need for the indirects through the DM?

[asanka, 2012/07/09 21:13:46]

Hmm. That makes sense. I didn't see a very clean way to get at the CDMD from
here. Perhaps add a method to DownloadService to return the
ChromeDownloadManagerDelegate for the profile?

[Randy Smith (Not in Mondays), 2012/07/10 18:33:09]

I think it's already present, isn't it? 
(DownloadService::GetDownloadManagerDelegate())

[asanka, 2012/07/11 20:03:32]

Hmm. I'd like to avoid up-casting if possible, but I think that should be okay.

   }
 
   if (remove_mask & REMOVE_COOKIES) {
     content::RecordAction(UserMetricsAction("ClearBrowsingData_Cookies"));
     // Since we are running on the UI thread don't call GetURLRequestContext().
     net::URLRequestContextGetter* rq_context = profile_->GetRequestContext();
     if (rq_context) {
       ++waiting_for_clear_cookies_count_;
       BrowserThread::PostTask(
           BrowserThread::IO, FROM_HERE,
@@ skipping 555 matching lines @@
       BrowserThread::UI, FROM_HERE,
       base::Bind(&BrowsingDataRemover::OnClearedServerBoundCerts,
                  base::Unretained(this)));
 }
 
 void BrowsingDataRemover::OnClearedServerBoundCerts() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   waiting_for_clear_server_bound_certs_ = false;
   NotifyAndDeleteIfDone();
 }