Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4949)

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/downloads_dom_handler.cc
diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc
index 514ae7a0157fa46445cbfb804f5e7814e6292aef..3c9f22dc8b17726f8fba8f69e50ba2e8b0075ff9 100644
--- a/chrome/browser/ui/webui/downloads_dom_handler.cc
+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc
@@ -179,14 +179,6 @@ void DownloadsDOMHandler::OnDownloadUpdated(content::DownloadItem* download) {
if (it == download_items_.end())
return;
- if (download->GetState() == content::DownloadItem::REMOVING) {
- (*it)->RemoveObserver(this);
- *it = NULL;
- // A later ModelChanged() notification will change the WebUI's
- // view of the downloads list.
- return;
- }
-
const int id = static_cast<int>(it - download_items_.begin());
ListValue results_value;
@@ -194,6 +186,17 @@ void DownloadsDOMHandler::OnDownloadUpdated(content::DownloadItem* download) {
web_ui()->CallJavascriptFunction("downloadUpdated", results_value);
}
+void DownloadsDOMHandler::OnDownloadDestroyed(
+ content::DownloadItem* download) {
+ download->RemoveObserver(this);
+ OrderedDownloads::iterator it = std::find(download_items_.begin(),
+ download_items_.end(),
+ download);
+ *it = NULL;
+ // A later ModelChanged() notification will change the WebUI's
+ // view of the downloads list.
+}
+
// A download has started or been deleted. Query our DownloadManager for the
// current set of downloads.
void DownloadsDOMHandler::ModelChanged(content::DownloadManager* manager) {

Powered by Google App Engine
This is Rietveld 408576698