content/browser/download/download_manager_impl.cc - Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_item_impl.cc ('K') | « content/browser/download/download_item_impl.cc ('k') | content/browser/download/drag_download_file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_manager_impl.cc

diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc

index 4d53082f185260066a670e852c7ee8956b4b9ce2..f96942b433cf5edb5406e0a8c3d1aa840e4e5ea5 100644

--- a/content/browser/download/download_manager_impl.cc

+++ b/content/browser/download/download_manager_impl.cc

@@ -613,14 +613,6 @@ void DownloadManagerImpl::OnResponseCompleted(int32 download_id,

}

void DownloadManagerImpl::AssertStateConsistent(DownloadItem* download) const {

- if (download->GetState() == DownloadItem::REMOVING) {

- DCHECK(!ContainsKey(downloads_, download->GetId()));

- DCHECK(!ContainsKey(active_downloads_, download->GetId()));

- DCHECK(!ContainsKey(history_downloads_, download->GetDbHandle()));

- return;

- }

- // Should be in downloads_ if we're not REMOVING.

CHECK(ContainsKey(downloads_, download->GetId()));

// Check history_downloads_ consistency.