chrome/browser/download/download_util.cc - Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_util.cc

Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_test_observer.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.h » ('j') | content/browser/download/download_item_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_util.cc

diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc

index 76b613ce6e47d46dc0bab8d06266b78026ccdfca..8f89681cca58086bfd357ef93e8a19a5323eeffd 100644

--- a/chrome/browser/download/download_util.cc

+++ b/chrome/browser/download/download_util.cc

@@ -514,8 +514,6 @@ DictionaryValue* CreateDownloadItemValue(DownloadItem* download, int id) {

file_value->SetString("state", "DANGEROUS");

else

file_value->SetString("state", "COMPLETE");

- } else if (download->GetState() == DownloadItem::REMOVING) {

- file_value->SetString("state", "REMOVING");

} else {

NOTREACHED() << "state undefined";

}