Switched from having one URLRequestJobFactory per profile to having one per context.

Switched from having one URLRequestJobFactory per profile to having one per context.
This change will allow a different set of protocol handlers to be added for
each context.

Future cls will replace static job factories with protocol handlers that will
then be added to these instances of URLRequestJobFactory.

Note: this depends on
http://codereview.chromium.org/10534100/.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145361

[shalev, 2012-06-29 15:37:38]

Hi Matt,

This is the cl with the factory changes in profile. Please take a look.

[mmenke, 2012-06-29 16:07:55]

LGTM.  You'll need to have a profile OWNER take a look before landing.

[willchan no longer on Chromium, 2012-06-29 17:21:30]

I'll take a look. Matt, I'd be happy for you to get familiar with
ProfileIOData so I can share reviews with you there.


On Fri, Jun 29, 2012 at 9:07 AM, <mmenke@chromium.org> wrote:

> LGTM.  You'll need to have a profile OWNER take a look before landing.
>
>
http://codereview.chromium.**org/10704021/<http://codereview.chromium.org/107...
>

[mmenke, 2012-06-29 17:28:33]

Sounds good to me.  I do want to get a lot more familiar with how things work on
the Chrome side of things.

On 2012/06/29 17:21:30, willchan wrote:
> I'll take a look. Matt, I'd be happy for you to get familiar with
> ProfileIOData so I can share reviews with you there.
> 
> 
> On Fri, Jun 29, 2012 at 9:07 AM, <mailto:mmenke@chromium.org> wrote:
> 
> > LGTM.  You'll need to have a profile OWNER take a look before landing.
> >
> >
>
http://codereview.chromium.**org/10704021/%3Chttp://codereview.chromium.org/1...>
> >

[willchan no longer on Chromium, 2012-06-29 17:47:23]

lgtm

http://codereview.chromium.org/10704021/diff/2001/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl_io_data.cc (right):

http://codereview.chromium.org/10704021/diff/2001/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl_io_data.cc:451:
AddConnectInterceptor(job_factories[i]);
Do we really need a function for this? It's just a single statement. I think
it'll be more readable if you just inline the statement here rather than make
readers search for the function definition.

[shalev, 2012-07-03 18:28:44]

http://codereview.chromium.org/10704021/diff/2001/chrome/browser/profiles/pro...
File chrome/browser/profiles/profile_impl_io_data.cc (right):

http://codereview.chromium.org/10704021/diff/2001/chrome/browser/profiles/pro...
chrome/browser/profiles/profile_impl_io_data.cc:451:
AddConnectInterceptor(job_factories[i]);
On 2012/06/29 17:47:23, willchan wrote:
> Do we really need a function for this? It's just a single statement. I think
> it'll be more readable if you just inline the statement here rather than make
> readers search for the function definition.

Done.

[commit-bot: I haz the power, 2012-07-03 18:29:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shalev@chromium.org/10704021/10001

[commit-bot: I haz the power, 2012-07-03 18:54:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shalev@chromium.org/10704021/4011

[commit-bot: I haz the power, 2012-07-03 20:06:53]

Change committed as 145361