Fix MessageReader to handle errors properly.

remoting/protocol/message_reader_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/thread.h"
+#include "net/base/net_errors.h"
 #include "net/socket/socket.h"
 #include "remoting/protocol/fake_session.h"
 #include "remoting/protocol/message_reader.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "third_party/libjingle/source/talk/base/byteorder.h"
 
 using testing::_;
 using testing::DoAll;
 using testing::Mock;
@@ skipping 257 matching lines @@
   base::Closure done_task;
   EXPECT_CALL(callback_, OnMessage(_))
       .Times(1)
       .WillOnce(SaveArg<0>(&done_task));
   AddMessage(kTestMessage2);
   EXPECT_TRUE(CompareResult(messages_[1], kTestMessage2));
 
   done_task.Run();
 }
 
+// Read() returns error.
+TEST_F(MessageReaderTest, ReadError) {
+  socket_.set_next_read_error(net::ERR_FAILED);
+
+  // Add a message. It should never be read after the error above.
+  AddMessage(kTestMessage1);
+
+  EXPECT_CALL(callback_, OnMessage(_))
+      .Times(0);
+
+  InitReader();
+}
+
 }  // namespace protocol
 }  // namespace remoting