chrome/common/extensions/extension_messages.h - Issue 10703111: Cleanup: make ExtensionRequestSender manage its IPC responses directly, rather

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_messages.h

Issue 10703111: Cleanup: make ExtensionRequestSender manage its IPC responses directly, rather (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ScopedObserverify Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_render_message_filter.cc ('k') | chrome/renderer/extensions/extension_dispatcher.h » ('j') | chrome/renderer/resources/extensions/send_request.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_messages.h

diff --git a/chrome/common/extensions/extension_messages.h b/chrome/common/extensions/extension_messages.h

index 8499d0944a46beba056f1eb1d447e32055279ffa..c0e9e8b59cd44840ee37ff7ef9d396a327c51cdd 100644

--- a/chrome/common/extensions/extension_messages.h

+++ b/chrome/common/extensions/extension_messages.h

@@ -176,11 +176,11 @@ struct ParamTraits<ExtensionMsg_Loaded_Params> {

// The browser sends this message in response to all extension api calls. The

// response data (if any) is one of the base::Value subclasses, wrapped as the

// first element in a ListValue.

-IPC_MESSAGE_ROUTED4(ExtensionMsg_Response,

- int /* request_id */,

- bool /* success */,

- ListValue /* response wrapper (see comment above) */,

- std::string /* error */)

+IPC_MESSAGE_CONTROL4(ExtensionMsg_Response,

+ int /* request_id */,

+ bool /* success */,

+ ListValue /* response wrapper (see comment above) */,

+ std::string /* error */)

// This message is optionally routed. If used as a control message, it

// will call a javascript function in every registered context in the