Cleanup: make ExtensionRequestSender manage its IPC responses directly, rather

chrome/renderer/extensions/set_icon_natives.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/set_icon_natives.h"
 
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/extensions/extension_request_sender.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkColor.h"
@@ skipping 63 matching lines @@
       extension_args->Get(v8::String::New("0"))->ToObject();
 
   DictionaryValue* dict = new DictionaryValue();
   dict->Set("imageData", bitmap_value);
 
   if (details->Has(v8::String::New("tabId"))) {
     dict->SetInteger("tabId",
                      details->Get(v8::String::New("tabId"))->Int32Value());
   }
 
-  ListValue list_value;
-  list_value.Append(dict);
+  ListValue api_args;
+  api_args.Append(dict);
 
   std::string name = *v8::String::AsciiValue(args[0]);
-  int request_id = args[2]->Int32Value();
-  bool has_callback = args[3]->BooleanValue();
-  bool for_io_thread = args[4]->BooleanValue();
+  bool has_callback = args[2]->BooleanValue();
+  bool for_io_thread = args[3]->BooleanValue();
 
-  request_sender_->StartRequest(name,
-                                request_id,
-                                has_callback,
-                                for_io_thread,
-                                &list_value);
-  return v8::Undefined();
+  return v8::Integer::New(request_sender_->StartRequest(
+      name, has_callback, for_io_thread, &api_args));
 }
 
 }  // namespace extensions