content/renderer/media/peer_connection_handler_base.cc - Issue 10703095: New PeerConnection handler in Chrome to support latest PeerConnection draft

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/peer_connection_handler_base.cc

Issue 10703095: New PeerConnection handler in Chrome to support latest PeerConnection draft (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed code review comments by Ronghua. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/mock_peer_connection_impl.cc ('K') | « content/renderer/media/peer_connection_handler_base.h ('k') | content/renderer/media/rtc_peer_connection_handler.h » ('j') | content/renderer/media/rtc_peer_connection_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/peer_connection_handler_base.cc

diff --git a/content/renderer/media/peer_connection_handler_base.cc b/content/renderer/media/peer_connection_handler_base.cc

index 156d0f157a79473302218ec722adcdb04f5d01d3..aee660ab9facd252df10dcea51cce7c301b0cdb4 100644

--- a/content/renderer/media/peer_connection_handler_base.cc

+++ b/content/renderer/media/peer_connection_handler_base.cc

@@ -39,6 +39,16 @@ void PeerConnectionHandlerBase::AddStream(

DCHECK(native_stream);

}

+bool PeerConnectionHandlerBase::AddStream(

+ const WebKit::WebMediaStreamDescriptor& stream,

+ const webrtc::MediaConstraintsInterface* constraints) {

+ webrtc::LocalMediaStreamInterface* native_stream =

+ GetLocalNativeMediaStream(stream);

+ if (!native_stream)

+ return false;

+ return native_peer_connection_->AddStream(native_stream, constraints);

void PeerConnectionHandlerBase::RemoveStream(

const WebKit::WebMediaStreamDescriptor& stream) {

webrtc::LocalMediaStreamInterface* native_stream =