New PeerConnection handler in Chrome to support latest PeerConnection draft

content/renderer/renderer_webkitplatformsupport_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/metrics/histogram.h"
@@ skipping 78 matching lines @@
 using WebKit::WebIDBFactory;
 using WebKit::WebIDBKey;
 using WebKit::WebIDBKeyPath;
 using WebKit::WebKitPlatformSupport;
 using WebKit::WebMediaStreamCenter;
 using WebKit::WebMediaStreamCenterClient;
 using WebKit::WebPeerConnection00Handler;
 using WebKit::WebPeerConnection00HandlerClient;
 using WebKit::WebPeerConnectionHandler;
 using WebKit::WebPeerConnectionHandlerClient;
+using WebKit::WebRTCPeerConnectionHandler;
+using WebKit::WebRTCPeerConnectionHandlerClient;
 using WebKit::WebSerializedScriptValue;
 using WebKit::WebStorageNamespace;
 using WebKit::WebString;
 using WebKit::WebURL;
 using WebKit::WebVector;
 
 static bool g_sandbox_enabled = true;
 
 //------------------------------------------------------------------------------
 
@@ skipping 597 matching lines @@
     WebPeerConnection00HandlerClient* client) {
   WebFrame* web_frame = WebFrame::frameForCurrentContext();
   if (!web_frame)
     return NULL;
   RenderViewImpl* render_view = RenderViewImpl::FromWebView(web_frame->view());
   if (!render_view)
     return NULL;
   return render_view->CreatePeerConnectionHandlerJsep(client);
 }
 
+WebRTCPeerConnectionHandler*
+RendererWebKitPlatformSupportImpl::createRTCPeerConnectionHandler(
+    WebRTCPeerConnectionHandlerClient* client) {
+  WebFrame* web_frame = WebFrame::frameForCurrentContext();
+  if (web_frame) {

[Ronghua Wu (Left Chromium), 2012/08/14 00:59:03]

I think the format in createPeerConnection00Handler is clearer:
if (!web_frame) {
  return NULL;
}

[perkj_chrome, 2012/08/14 09:15:40]

please talk to your colleague next to you :->
Ok - will change it back.

please also note the indentation of the method names that don't fit on one line
in this file. Seems like some uses this indentation and some indent the method
names.

On 2012/08/14 00:59:03, Ronghua Wu wrote:

[Ronghua Wu (Left Chromium), 2012/08/15 00:57:32]

:) This is the format preferred in libjingle and I also personally think it's
clearer. If chromium has another preference I'm ok with both.

+    RenderViewImpl* view = RenderViewImpl::FromWebView(web_frame->view());
+    if (view) {
+      return view->CreateRTCPeerConnectionHandler(client);
+    }
+  }
+  return NULL;
+}
+
 //------------------------------------------------------------------------------
 
 WebMediaStreamCenter*
 RendererWebKitPlatformSupportImpl::createMediaStreamCenter(
     WebMediaStreamCenterClient* client) {
   RenderThreadImpl* render_thread = RenderThreadImpl::current();
   DCHECK(render_thread);
   if (!render_thread)
     return NULL;
   return render_thread->CreateMediaStreamCenter(client);
 }
 
 // static
 bool RendererWebKitPlatformSupportImpl::SetSandboxEnabledForTesting(
     bool enable) {
   bool was_enabled = g_sandbox_enabled;
   g_sandbox_enabled = enable;
   return was_enabled;
 }
 
 GpuChannelHostFactory*
 RendererWebKitPlatformSupportImpl::GetGpuChannelHostFactory() {
   return RenderThreadImpl::current();
 }