New PeerConnection handler in Chrome to support latest PeerConnection draft

content/renderer/media/mock_peer_connection_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/mock_media_stream_dependency_factory.h"
 #include "content/renderer/media/mock_peer_connection_impl.h"
 
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 30 matching lines @@
 
 MockPeerConnectionImpl::MockPeerConnectionImpl(
     MockMediaStreamDependencyFactory* factory)
     : dependency_factory_(factory),
       local_streams_(new talk_base::RefCountedObject<MockStreamCollection>),
       remote_streams_(new talk_base::RefCountedObject<MockStreamCollection>),
       hint_audio_(false),
       hint_video_(false),
       action_(kAnswer),
       ice_options_(kOnlyRelay),
-      ready_state_(kNew) {
+      sdp_mline_index_(-1),
+      ready_state_(kNew),
+      ice_state_(kIceNew) {
 }
 
 MockPeerConnectionImpl::~MockPeerConnectionImpl() {}
 
 talk_base::scoped_refptr<StreamCollectionInterface>
 MockPeerConnectionImpl::local_streams() {
   return local_streams_;
 }
 
 talk_base::scoped_refptr<StreamCollectionInterface>
@@ skipping 60 matching lines @@
     webrtc::SessionDescriptionInterface* desc) {
   action_ = action;
   remote_desc_.reset(desc);
   return desc->ToString(&description_sdp_);
 }
 
 bool MockPeerConnectionImpl::ProcessIceMessage(
     const webrtc::IceCandidateInterface* ice_candidate) {
   sdp_mid_ = ice_candidate->sdp_mid();
   sdp_mline_index_ = ice_candidate->sdp_mline_index();
   return ice_candidate->ToString(&ice_sdp_);

[Ronghua Wu (Left Chromium), 2012/08/14 00:59:03]

Call AddCandidate directly.

[perkj_chrome, 2012/08/14 09:15:40]

Done.

 }
 
 const webrtc::SessionDescriptionInterface*
 MockPeerConnectionImpl::local_description() const {
   return local_desc_.get();
 }
 
 const webrtc::SessionDescriptionInterface*
 MockPeerConnectionImpl::remote_description() const {
   return remote_desc_.get();
 }
 
 void MockPeerConnectionImpl::AddRemoteStream(MediaStreamInterface* stream) {
   remote_streams_->AddStream(stream);
 }
 
 void MockPeerConnectionImpl::CreateOffer(
     CreateSessionDescriptionObserver* observer,
     const MediaConstraintsInterface* constraints) {
+  DCHECK(observer);
   NOTIMPLEMENTED();
 }
 
 void MockPeerConnectionImpl::CreateAnswer(
     CreateSessionDescriptionObserver* observer,
     const MediaConstraintsInterface* constraints) {
   NOTIMPLEMENTED();
 }
 
 void MockPeerConnectionImpl::SetLocalDescription(
     SetSessionDescriptionObserver* observer,
     SessionDescriptionInterface* desc) {
-  NOTIMPLEMENTED();
+  local_desc_.reset(desc);

[Ronghua Wu (Left Chromium), 2012/08/14 00:59:03]

call the observer?

[Ronghua Wu (Left Chromium), 2012/08/14 00:59:03]

Is desc->ToString(&description_sdp_); needed here?

[perkj_chrome, 2012/08/14 09:15:40]

Can't do that unfortunately since the WebKit class WebKit::WebRTCVoidRequest
can't be used from a unit test.

[perkj_chrome, 2012/08/14 09:15:40]

No - but it make sence to keep them the same as the old ones.

 }
 
 void MockPeerConnectionImpl::SetRemoteDescription(
     SetSessionDescriptionObserver* observer,
     SessionDescriptionInterface* desc) {
-  NOTIMPLEMENTED();
+  remote_desc_.reset(desc);

[Ronghua Wu (Left Chromium), 2012/08/14 00:59:03]

call the observer?

[perkj_chrome, 2012/08/14 09:15:40]

dito

 }
 
 bool MockPeerConnectionImpl::UpdateIce(
     const IceServers& configuration,
     const MediaConstraintsInterface* constraints) {
-  NOTIMPLEMENTED();
-  return false;
+  return true;
 }
 
 bool MockPeerConnectionImpl::AddIceCandidate(
     const IceCandidateInterface* candidate) {
-  NOTIMPLEMENTED();
-  return false;
+  sdp_mid_ = candidate->sdp_mid();
+  sdp_mline_index_ = candidate->sdp_mline_index();
+  return candidate->ToString(&ice_sdp_);
 }
 
 PeerConnectionInterface::IceState MockPeerConnectionImpl::ice_state() {
-  NOTIMPLEMENTED();
-  return kIceNew;
+  return ice_state_;
 }
 
 }  // namespace webrtc