New PeerConnection handler in Chrome to support latest PeerConnection draft

content/renderer/renderer_webkitplatformsupport_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/metrics/histogram.h"
@@ skipping 78 matching lines @@
 using WebKit::WebIDBFactory;
 using WebKit::WebIDBKey;
 using WebKit::WebIDBKeyPath;
 using WebKit::WebKitPlatformSupport;
 using WebKit::WebMediaStreamCenter;
 using WebKit::WebMediaStreamCenterClient;
 using WebKit::WebPeerConnection00Handler;
 using WebKit::WebPeerConnection00HandlerClient;
 using WebKit::WebPeerConnectionHandler;
 using WebKit::WebPeerConnectionHandlerClient;
+using WebKit::WebRTCPeerConnectionHandler;
+using WebKit::WebRTCPeerConnectionHandlerClient;
 using WebKit::WebSerializedScriptValue;
 using WebKit::WebStorageNamespace;
 using WebKit::WebString;
 using WebKit::WebURL;
 using WebKit::WebVector;
 
 static bool g_sandbox_enabled = true;
 
 //------------------------------------------------------------------------------
 
@@ skipping 597 matching lines @@
     WebPeerConnection00HandlerClient* client) {
   WebFrame* web_frame = WebFrame::frameForCurrentContext();
   if (!web_frame)
     return NULL;
   RenderViewImpl* render_view = RenderViewImpl::FromWebView(web_frame->view());
   if (!render_view)
     return NULL;
   return render_view->CreatePeerConnectionHandlerJsep(client);
 }
 
+WebRTCPeerConnectionHandler*
+RendererWebKitPlatformSupportImpl::createRTCPeerConnectionHandler(
+    WebRTCPeerConnectionHandlerClient* client) {
+  WebFrame* web_frame = WebFrame::frameForCurrentContext();
+  if (!web_frame)
+    return NULL;
+  RenderViewImpl* render_view = RenderViewImpl::FromWebView(web_frame->view());
+  if (!render_view)
+    return NULL;
+  return render_view->CreateRTCPeerConnectionHandler(client);

[wjia(left Chromium), 2012/08/12 17:06:52]

How about:
if (web_frame) {
  RenderViewImpl* render_view = RenderViewImpl::FromWebView(web_frame->view());
  if (render_view)
    return render_view->CreateRTCPeerConnectionHandler(client);
}

return NULL;

[perkj_chrome, 2012/08/13 07:35:46]

Sounds good. In a number of reviews I have had comments about prefering short
exits. But your suggestion looks nicer here.
On 2012/08/12 17:06:52, wjia wrote:

+}
+
 //------------------------------------------------------------------------------
 
 WebMediaStreamCenter*
 RendererWebKitPlatformSupportImpl::createMediaStreamCenter(
     WebMediaStreamCenterClient* client) {
   RenderThreadImpl* render_thread = RenderThreadImpl::current();
   DCHECK(render_thread);
   if (!render_thread)
     return NULL;
   return render_thread->CreateMediaStreamCenter(client);
 }
 
 // static
 bool RendererWebKitPlatformSupportImpl::SetSandboxEnabledForTesting(
     bool enable) {
   bool was_enabled = g_sandbox_enabled;
   g_sandbox_enabled = enable;
   return was_enabled;
 }
 
 GpuChannelHostFactory*
 RendererWebKitPlatformSupportImpl::GetGpuChannelHostFactory() {
   return RenderThreadImpl::current();
 }