Fix unit test to allow repeated successful runs by avoiding a function static variable in tests.

ppapi/shared_impl/ppapi_globals.cc

Index: ppapi/shared_impl/ppapi_globals.cc
diff --git a/ppapi/shared_impl/ppapi_globals.cc b/ppapi/shared_impl/ppapi_globals.cc
index 80a4ee2417fc8ecb448fde261f411f8284abe73c..510a821f6bde119bb8c352904fc78c46a72fb58e 100644
--- a/ppapi/shared_impl/ppapi_globals.cc
+++ b/ppapi/shared_impl/ppapi_globals.cc
@@ -43,9 +43,9 @@ void PpapiGlobals::SetPpapiGlobalsOnThreadForTest(PpapiGlobals* ptr) {
 }
 
 base::MessageLoopProxy* PpapiGlobals::GetMainThreadMessageLoop() {
-  CR_DEFINE_STATIC_LOCAL(scoped_refptr<base::MessageLoopProxy>, proxy,
-      (base::MessageLoopProxy::current()));
-  return proxy.get();
+  if (!message_loop_proxy_.get())
+    message_loop_proxy_ = base::MessageLoopProxy::current();

[brettw, 2012/07/13 16:36:22]

I think you should just set this in the constructor rather than trying to do it
lazily here.

[dmichael (off chromium), 2012/07/13 16:44:58]

Agree. The important thing is that base::MessageLoopProxy::current is called on
the main thread. Doing it in the constructor will do that nicely. And then we
can probably get rid of a "special" call to GetMainThreadMessageLoop:
http://code.google.com/searchframe#OAMlx_jo-ck/src/webkit/plugins/ppapi/plugi...

+  return message_loop_proxy_.get();
 }
 
 bool PpapiGlobals::IsHostGlobals() const {