Fix unit test to allow repeated successful runs by avoiding a function static variable in tests.

ppapi/shared_impl/ppapi_globals.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_SHARED_IMPL_PPAPI_GLOBALS_H_
 #define PPAPI_SHARED_IMPL_PPAPI_GLOBALS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
 #include "base/threading/thread_local.h"  // For testing purposes only.
 #include "ppapi/c/dev/ppb_console_dev.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_module.h"
 #include "ppapi/shared_impl/api_id.h"
 #include "ppapi/shared_impl/ppapi_shared_export.h"
 
 namespace base {
 class Lock;
 class MessageLoopProxy;
@@ skipping 77 matching lines @@
   virtual thunk::ResourceCreationAPI* GetResourceCreationAPI(
       PP_Instance instance) = 0;
 
   // Returns the PP_Module associated with the given PP_Instance, or 0 on
   // failure.
   virtual PP_Module GetModuleForInstance(PP_Instance instance) = 0;
 
   // Returns the base::MessageLoopProxy for the main thread. Note that this must
   // be called on the main thread the first time so that it can initialize
   // its static data.
-  base::MessageLoopProxy* GetMainThreadMessageLoop();
+  // Virtual for testing.

[brettw, 2012/07/13 16:36:22]

I think you can revert this part.

+  virtual base::MessageLoopProxy* GetMainThreadMessageLoop();
 
   // Returns the command line for the process.
   virtual std::string GetCmdLine() = 0;
 
   // Preloads the font on Windows, does nothing on other platforms.
   // TODO(brettw) remove this by passing the instance into the API so we don't
   // have to have it on the globals.
   virtual void PreCacheFontForFlash(const void* logfontw) = 0;
 
   virtual bool IsHostGlobals() const;
   virtual bool IsPluginGlobals() const;
 
  private:
   // Return the thread-local pointer which is used only for unit testing. It
   // should always be NULL when running in production. It allows separate
   // threads to have distinct "globals".
   static PpapiGlobals* GetThreadLocalPointer();
 
   static PpapiGlobals* ppapi_globals_;
 
+  scoped_refptr<base::MessageLoopProxy> message_loop_proxy_;
+
   DISALLOW_COPY_AND_ASSIGN(PpapiGlobals);
 };
 
 }  // namespace ppapi
 
 #endif  // PPAPI_SHARED_IMPL_PPAPI_GLOBALS_H_