Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 10702141: Introduced TestURLFetcher::DelegateForTests interface to allow event-driven end-to-end tests of cla… (Closed)

Created:
8 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Introduced TestURLFetcher::DelegateForTests interface to allow event-driven end-to-end tests of classes using URLFetcher. BUG=116954 TEST=none. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146315

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M net/url_request/test_url_fetcher_factory.h View 6 chunks +25 lines, -0 lines 0 comments Download
M net/url_request/test_url_fetcher_factory.cc View 8 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Primiano Tucci (use gerrit)
8 years, 5 months ago (2012-07-11 09:08:13 UTC) #1
ramant (doing other things)
lgtm
8 years, 5 months ago (2012-07-11 16:56:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/primiano@chromium.org/10702141/2001
8 years, 5 months ago (2012-07-12 09:29:29 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 10:26:47 UTC) #4
Try job failure for 10702141-2001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698