Instrument serial API code to make testing easier.

chrome/browser/extensions/api/serial/serial_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/serial/serial_api.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/api/api_resource_controller.h"
 #include "chrome/browser/extensions/api/serial/serial_connection.h"
 #include "chrome/browser/extensions/api/serial/serial_port_enumerator.h"
@@ skipping 70 matching lines @@
 }
 
 void SerialOpenFunction::AsyncWorkStart() {
   Work();
 }
 
 void SerialOpenFunction::Work() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   const SerialPortEnumerator::StringSet name_set(
     SerialPortEnumerator::GenerateValidSerialPortNames());
-  if (SerialPortEnumerator::DoesPortExist(name_set, params_->port)) {
-    SerialConnection* serial_connection = new SerialConnection(
+  if (DoesPortExist(params_->port)) {
+    SerialConnection* serial_connection = CreateSerialConnection(
       params_->port,
       bitrate_,
       event_notifier_);
     CHECK(serial_connection);
     int id = controller()->AddAPIResource(serial_connection);
     CHECK(id);
 
     bool open_result = serial_connection->Open();
     if (!open_result) {
       serial_connection->Close();
       controller()->RemoveSerialConnection(id);
       id = -1;
     }
 
     DictionaryValue* result = new DictionaryValue();
     result->SetInteger(kConnectionIdKey, id);
     result_.reset(result);
     AsyncWorkCompleted();
   } else {
     DictionaryValue* result = new DictionaryValue();
     result->SetInteger(kConnectionIdKey, -1);
     result_.reset(result);
     AsyncWorkCompleted();
   }
 }
 
+SerialConnection* SerialOpenFunction::CreateSerialConnection(
+    const std::string& port,
+    int bitrate,
+    APIResourceEventNotifier* event_notifier) {
+  return new SerialConnection(port, bitrate, event_notifier);
+}
+
+bool SerialOpenFunction::DoesPortExist(const std::string& port) {
+  const SerialPortEnumerator::StringSet name_set(
+    SerialPortEnumerator::GenerateValidSerialPortNames());
+  return SerialPortEnumerator::DoesPortExist(name_set, params_->port);
+}
+
 bool SerialOpenFunction::Respond() {
   return true;
 }
 
 SerialCloseFunction::SerialCloseFunction() {
 }
 
 SerialCloseFunction::~SerialCloseFunction() {
 }
 
@@ skipping 121 matching lines @@
   }
 
   result_.reset(Value::CreateBooleanValue(flush_result));
 }
 
 bool SerialFlushFunction::Respond() {
   return true;
 }
 
 }  // namespace extensions