Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: net/url_request/url_request_http_job.h

Issue 10702137: Replaced static URLRequestHTTPJob factory with non-static protocol handler for HTTP jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index 39451c63687f0920c197e9a8569984fa38e6829b..e84fb289d19d2294d1298cdd9d6e8e9b24fbd05d 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -21,20 +21,38 @@
namespace net {
+class CookieStore;
+class FraudulentCertificateReporter;
class HttpResponseHeaders;
class HttpResponseInfo;
class HttpTransaction;
+class HttpTransactionFactory;
+class NetworkDelegate;
+class SSLConfigService;
+class TransportSecurityState;
class URLRequestContext;
+class URLRequestThrottlerManager;
// A URLRequestJob subclass that is built on top of HttpTransaction. It
// provides an implementation for both HTTP and HTTPS.
class URLRequestHttpJob : public URLRequestJob {
public:
+ friend class HttpProtocolHandler;
static URLRequestJob* Factory(URLRequest* request,
const std::string& scheme);
protected:
- explicit URLRequestHttpJob(URLRequest* request);
+ URLRequestHttpJob(
+ URLRequest* request,
+ HttpTransactionFactory* http_transaction_factory,
+ NetworkDelegate* network_delegate,
+ URLRequestThrottlerManager* throttler_manager,
+ const std::string& accept_language,
+ const std::string& accept_charset,
+ CookieStore* cookie_store,
+ FraudulentCertificateReporter* fraudulent_certificate_reporter,
+ SSLConfigService* ssl_config_service,
+ TransportSecurityState* transport_security_state);
// Shadows URLRequestJob's version of this method so we can grab cookies.
void NotifyHeadersComplete();
@@ -234,6 +252,16 @@ class URLRequestHttpJob : public URLRequestJob {
// to inform the NetworkDelegate that it may not call back.
bool awaiting_callback_;
+ HttpTransactionFactory* http_transaction_factory_;
+ NetworkDelegate* network_delegate_;
+ URLRequestThrottlerManager* throttler_manager_;
+ std::string accept_language_;
+ std::string accept_charset_;
mmenke 2012/07/18 16:21:53 nit: Can make these strings const.
shalev 2012/07/23 21:00:21 Done.
+ CookieStore* cookie_store_;
+ FraudulentCertificateReporter* fraudulent_certificate_reporter_;
+ SSLConfigService* ssl_config_service_;
+ TransportSecurityState* transport_security_state_;
+
DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob);
};

Powered by Google App Engine
This is Rietveld 408576698