Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: net/url_request/url_request_http_job.h

Issue 10702137: Replaced static URLRequestHTTPJob factory with non-static protocol handler for HTTP jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes requested in comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index 39451c63687f0920c197e9a8569984fa38e6829b..e07fe22dccec6d2d0eb906f631f820cbc0c9c7a3 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -21,10 +21,17 @@
namespace net {
+class CookieStore;
+class FraudulentCertificateReporter;
class HttpResponseHeaders;
class HttpResponseInfo;
class HttpTransaction;
+class HttpTransactionFactory;
+class NetworkDelegate;
+class SSLConfigService;
+class TransportSecurityState;
class URLRequestContext;
+class URLRequestThrottlerManager;
// A URLRequestJob subclass that is built on top of HttpTransaction. It
// provides an implementation for both HTTP and HTTPS.
@@ -34,7 +41,17 @@ class URLRequestHttpJob : public URLRequestJob {
const std::string& scheme);
protected:
- explicit URLRequestHttpJob(URLRequest* request);
+ URLRequestHttpJob(
+ URLRequest* request,
+ HttpTransactionFactory* http_transaction_factory,
+ NetworkDelegate* network_delegate,
+ URLRequestThrottlerManager* throttler_manager,
+ const std::string& accept_language,
+ const std::string& accept_charset,
+ CookieStore* cookie_store,
+ FraudulentCertificateReporter* fraudulent_certificate_reporter,
+ SSLConfigService* ssl_config_service,
+ TransportSecurityState* transport_security_state);
// Shadows URLRequestJob's version of this method so we can grab cookies.
void NotifyHeadersComplete();
@@ -134,6 +151,7 @@ class URLRequestHttpJob : public URLRequestJob {
bool is_cached_content_;
private:
+ friend class HttpProtocolHandler;
enum CompletionCause {
ABORTED,
FINISHED
@@ -234,6 +252,16 @@ class URLRequestHttpJob : public URLRequestJob {
// to inform the NetworkDelegate that it may not call back.
bool awaiting_callback_;
+ HttpTransactionFactory* http_transaction_factory_;
+ NetworkDelegate* network_delegate_;
+ URLRequestThrottlerManager* throttler_manager_;
+ const std::string accept_language_;
+ const std::string accept_charset_;
+ CookieStore* cookie_store_;
+ FraudulentCertificateReporter* fraudulent_certificate_reporter_;
+ SSLConfigService* ssl_config_service_;
+ TransportSecurityState* transport_security_state_;
+
DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob);
};

Powered by Google App Engine
This is Rietveld 408576698