Add test for failing rename in BaseFileTest.

Add test for failing rename in BaseFileTest.

Also clean up temporary directory in BaseFileTest.ReadonlyBaseFile.

BUG=none
TEST=content_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146477

[asanka, 2012-07-11 17:00:22]

A few leftovers from the failing rename test investigation.

[Randy Smith (Not in Mondays), 2012-07-11 17:13:17]

http://codereview.chromium.org/10702130/diff/2001/content/browser/download/ba...
File content/browser/download/base_file_unittest.cc (right):

http://codereview.chromium.org/10702130/diff/2001/content/browser/download/ba...
content/browser/download/base_file_unittest.cc:483:
EXPECT_EQ(net::ERR_ACCESS_DENIED, base_file_->Rename(new_path));
I'm concerned about this test, for the reasons you mentioned to me.  More
abstractly, on posix, I consider rename to be a directory operation, not a file
operation; i.e. it would be reasonable to implement it by *not* closing and
reopening the file, but instead by just doing the rename at the directory level.
 In that case, I think this test would fail. 

Maybe import the test I just added to download_file in
http://codereview.chromium.org/10689093/?

[Randy Smith (Not in Mondays), 2012-07-12 03:19:11]

LGTM; sorry about the earlier confusion.

[commit-bot: I haz the power, 2012-07-12 15:34:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/10702130/2001

[commit-bot: I haz the power, 2012-07-12 20:42:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/10702130/2001

[commit-bot: I haz the power, 2012-07-12 22:59:58]

Change committed as 146477