Adds browser preferences to configure first-run flow on Windows 8.

chrome/installer/util/master_preferences_constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the constants used to process master_preferences files
 // used by setup and first run.
 
 #ifndef CHROME_INSTALLER_UTIL_MASTER_PREFERENCES_CONSTANTS_H_
 #define CHROME_INSTALLER_UTIL_MASTER_PREFERENCES_CONSTANTS_H_
 
@@ skipping 32 matching lines @@
 extern const char kDistroImportHistoryPref[];
 // Boolean pref that triggers silent import of the default browser homepage.
 extern const char kDistroImportHomePagePref[];
 // Boolean pref that triggers silent import of the default search engine.
 extern const char kDistroImportSearchPref[];
 // Integer. RLZ ping delay in seconds.
 extern const char kDistroPingDelay[];
 // Boolean pref that triggers loading the welcome page.
 extern const char kDistroShowWelcomePage[];
 // Boolean pref that triggers skipping the first run dialogs.
 extern const char kDistroSkipFirstRunPref[];

[gab, 2012/07/24 17:43:16]

There already seems to be a skip first run pref, I don't see why we need a new
one. OEMs that don't want first run dialogs just don't want them, I can't see a
case where they'd want some, but not default browser one...

[motek., 2012/07/25 10:08:59]

Hmm... weird. I don't see anything in a diff here. Have I added anything here? I
am not sure how to understand your remark. If this is a general comment then we
should discuss it with PMs, their comments led me to believe that was expressly
discussed with some OEMs. 
Due to that flag below, we can have a valid first-run experience with different
levels of 'intrusiveness'. 

[gab, 2012/07/25 16:39:55]

Yes this a general comment as I thought we should make the other pref generic
and it turns out a generic "no_first_run_dialogs" pref already exists here.

I talked about it with santhosh yesterday after finding this pref. We agreed
that we only need one pref to disable any kind of first run (i.e. there is no
OEM that would want some part of first run, but not all.... if an OEM doesn't
want first run stuff they don't want any, point final imo).

Given this generic pref already exists I feel we should use it (i.e. not
introduce kSuppressFirstRunDefaultBrowserPrompt).

The only downside I can see is that we end up disabling our first run things
before even being requested for the OEMs that already have this pref turned on
(but again they'd probably just be mad that we turned some first run things back
on although they have this pref and would eventually just turn on both...)

@gideonwald, @santhoshba: Can you comment on this please?

 // Boolean. Do not show first run bubble, even if it would otherwise be shown.
 extern const char kDistroSuppressFirstRunBubble[];
 // Boolean. Do not launch Chrome after first install. Cmd line override present.
 extern const char kDoNotLaunchChrome[];
 // Boolean. Do not register with Google Update to have Chrome launched after
 // install. Cmd line override present.
 extern const char kDoNotRegisterForUpdateLaunch[];
 // String.  Specifies the file path to write logging info to.
 extern const char kLogFile[];
 // Boolean. Register Chrome as default browser. Cmd line override present.
 extern const char kMakeChromeDefault[];
 // Boolean. Register Chrome as default browser for the current user.
 extern const char kMakeChromeDefaultForUser[];
 // Boolean. Expect to be run by an MSI installer. Cmd line override present.
 extern const char kMsi[];
 // Boolean. Support installing multiple products at once.
 extern const char kMultiInstall[];
 // Boolean. Show EULA dialog before install.
 extern const char kRequireEula[];
+// Boolean. Indicates that the first-run 'set-as-default' dialog should not be
+// shown. Relevant in Windows 8 context only.

[gab, 2012/07/24 17:43:16]

In general it's preferable to refer to Windows 8+ (instead of just Windows 8) so
that comments are still valid when future versions of Windows come out.

[motek., 2012/07/25 10:08:59]

Done.

+extern const char kSuppressFirstRunDefaultBrowserPrompt[];
 // Boolean. Install Chrome to system wise location. Cmd line override present.
 extern const char kSystemLevel[];
 // Boolean. Run installer in verbose mode. Cmd line override present.
 extern const char kVerboseLogging[];
 // Name of the block that contains the extensions on the master preferences.
 extern const char kExtensionsBlock[];
 }  // namespace master_preferences
 }  // namespace installer
 
 #endif  // CHROME_INSTALLER_UTIL_MASTER_PREFERENCES_CONSTANTS_H_