Refactor chrome.cookies API to use JSON schema compiler.

chrome/browser/extensions/api/cookies/cookies_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines the Chrome Extensions Cookies API functions for accessing internet
 // cookies, as specified in the extension API JSON.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_COOKIES_COOKIES_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_COOKIES_COOKIES_API_H_
 #pragma once
@@ skipping 58 matching lines @@
 // common functionality for parsing cookies API function arguments.
 // Note that all of the functions in this file derive from
 // AsyncExtensionFunction, and are not threadsafe, so they should not be
 // concurrently accessed from multiple threads. They modify |result_| and other
 // member variables directly.
 // See chrome/browser/extensions/extension_function.h for more information.
 class CookiesFunction : public AsyncExtensionFunction {
  protected:
   virtual ~CookiesFunction() {}
 
-  // Looks for a 'url' value in the given details dictionary and constructs a
-  // GURL from it. Returns false and assigns the internal error_ value if the
-  // URL is invalid or isn't found in the dictionary. If check_host_permissions
-  // is true, the URL is also checked against the extension's host permissions,
-  // and if there is no permission for the URL, this function returns false.
-  bool ParseUrl(const base::DictionaryValue* details, GURL* url,
-                bool check_host_permissions);
+  // Constructs a GURL from the given url string. Returns false and assigns the
+  // internal error_ value if the URL is invalid. If check_host_permissions is
+  // true, the URL is also checked against the extension's host permissions, and
+  // if there is no permission for the URL, this function returns false.
+  bool ParseUrl(std::string url_string, GURL* url, bool check_host_permissions);

[Aaron Boodman, 2012/07/04 00:04:31]

Input params that are non-primitive should almost always be const ref.

[mitchellwrosen, 2012/07/04 02:04:40]

Done.

 
-  // Checks the given details dictionary for a 'storeId' value, and retrieves
-  // the cookie store context and the store ID associated with it.  If the
-  // 'storeId' value isn't found in the dictionary, the current execution
-  // context's cookie store context is retrieved. Returns false on error and
-  // assigns the internal error_ value if that occurs.
-  // At least one of the output parameters store and store_id should be
-  // non-NULL.
-  bool ParseStoreContext(const base::DictionaryValue* details,
+  // If |store_id| is non-NULL, retrieves the specified store. Otherwise,
+  // retrieves the current execution context's store.  Returns false on error
+  // and assigns the internal error_ value if that occurs. At least one of the
+  // output parameters context and out_store_id should be non-NULL.
+  bool ParseStoreContext(std::string* in_store_id,

[Aaron Boodman, 2012/07/04 00:04:31]

Can you just have a single std::string* store_id at the end, and assign to it if
NULL?

[mitchellwrosen, 2012/07/04 02:04:40]

Can you elaborate on this? How can you assign to something if it's NULL? I do
agree the parameters are a little weird, though. If |in_store_id| is non-NULL,
then *out_store_id is just going to be set to *in_store_id is, which we already
have. However if |in_store_id| is NULL then we need an out-parameter to report
the store ID of the current context. 

[Aaron Boodman, 2012/07/04 06:35:40]

Right you are. You could use empty string for the case NULL is being used for
today and combine them that way.

                          net::URLRequestContextGetter** context,
-                         std::string* store_id);
+                         std::string* out_store_id);
 };
 
 // Implements the cookies.get() extension function.
 class GetCookieFunction : public CookiesFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("cookies.get")
 
   GetCookieFunction();
 
  protected:
@@ skipping 102 matching lines @@
 
   // ExtensionFunction:
   // GetAllCookieStoresFunction is sync.
   virtual void Run() OVERRIDE;
   virtual bool RunImpl() OVERRIDE;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_COOKIES_COOKIES_API_H_