Improved UI for data preview copy/paste (dartbug.com/2197).

Improved UI for data preview copy/paste (dartbug.com/2197).

As per the conversation on dartbug.com/2197 this adds a context menu to the About Box and Log preview.
Committed: https://code.google.com/p/dart/source/detail?r=9375

[devoncarew, 2012-07-03 18:48:53]

lgtm

http://codereview.chromium.org/10702085/diff/2001/editor/tools/plugins/com.go...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/actions/CopyDetailsToClipboardAction.java
(right):

http://codereview.chromium.org/10702085/diff/2001/editor/tools/plugins/com.go...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/actions/CopyDetailsToClipboardAction.java:98:
"There was a problem when accessing the system clipboard.\nRetry?")) {
Looks good, although I think just presenting an error dialog works too (w/o
asking them to retry).

[danrubel, 2012-07-03 18:58:43]

lgtm

https://chromiumcodereview.appspot.com/10702085/diff/2001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/actions/CopyDetailsToClipboardAction.java
(right):

https://chromiumcodereview.appspot.com/10702085/diff/2001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/actions/CopyDetailsToClipboardAction.java:98:
"There was a problem when accessing the system clipboard.\nRetry?")) {
On 2012/07/03 18:48:53, devoncarew wrote:
> Looks good, although I think just presenting an error dialog works too (w/o
> asking them to retry).

Agreed... unless there is an overriding reason to facilitate a retry.

[pquitslund, 2012-07-03 19:15:58]

Thanks!

http://codereview.chromium.org/10702085/diff/2001/editor/tools/plugins/com.go...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/actions/CopyDetailsToClipboardAction.java
(right):

http://codereview.chromium.org/10702085/diff/2001/editor/tools/plugins/com.go...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/actions/CopyDetailsToClipboardAction.java:98:
"There was a problem when accessing the system clipboard.\nRetry?")) {
On 2012/07/03 18:58:43, danrubel wrote:
> On 2012/07/03 18:48:53, devoncarew wrote:
> > Looks good, although I think just presenting an error dialog works too (w/o
> > asking them to retry).
> 
> Agreed... unless there is an overriding reason to facilitate a retry.

I've seen this retry idiom used elsewhere in the eclipse platform bits so I
thought I'd follow suit.  My preference in general is for a retry if there's any
chance of success.  FWIW: I remember having issues in the past where OS
clipboard access was temporarily locked but haven't seen it in a while.  It's
possible that this code is more relevant to older OSes and may be a tad
gratuitous in the modern age.  In any event, we can certainly tweak it....