Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: base/android/jni_helper.h

Issue 10702083: Add ContentViewDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_helper.h
diff --git a/base/android/jni_helper.h b/base/android/jni_helper.h
index bd3579fc89929ef1333b43b2a0b41cfff5be4810..09f0587885de734bdc4dfd18abdb0c215f03cb1e 100644
--- a/base/android/jni_helper.h
+++ b/base/android/jni_helper.h
@@ -15,17 +15,21 @@
// calls the destructor) they'll need to provide their own synchronization.
class JavaObjectWeakGlobalRef {
public:
+ JavaObjectWeakGlobalRef();
+ JavaObjectWeakGlobalRef(const JavaObjectWeakGlobalRef& orig);
JavaObjectWeakGlobalRef(JNIEnv* env, jobject obj);
virtual ~JavaObjectWeakGlobalRef();
+ void operator=(const JavaObjectWeakGlobalRef& rhs);
+
base::android::ScopedJavaLocalRef<jobject> get(JNIEnv* env) const;
void reset();
private:
- jweak obj_;
+ void assign(const JavaObjectWeakGlobalRef& rhs);
joth 2012/09/13 20:09:12 nit: Assign
mkosiba (inactive) 2012/09/17 17:55:31 Done.
- DISALLOW_COPY_AND_ASSIGN(JavaObjectWeakGlobalRef);
+ jweak obj_;
};
// Get the real object stored in the weak reference returned as a

Powered by Google App Engine
This is Rietveld 408576698