Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: chrome/browser/sync/glue/bridged_sync_notifier.cc

Issue 10702074: Refactor sync-specific parts out of SyncNotifier/SyncNotifierObserver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: FOR_THE_HORDE Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/bridged_sync_notifier.cc
diff --git a/chrome/browser/sync/glue/bridged_sync_notifier.cc b/chrome/browser/sync/glue/bridged_sync_notifier.cc
index a9de0577de66a24b7cdadec89b28bd87952e21db..5e3f669937da088a6d12e30bb9938886a34af1fe 100644
--- a/chrome/browser/sync/glue/bridged_sync_notifier.cc
+++ b/chrome/browser/sync/glue/bridged_sync_notifier.cc
@@ -18,18 +18,12 @@ BridgedSyncNotifier::BridgedSyncNotifier(
BridgedSyncNotifier::~BridgedSyncNotifier() {
}
-void BridgedSyncNotifier::AddObserver(
- syncer::SyncNotifierObserver* observer) {
+void BridgedSyncNotifier::UpdateRegisteredIds(
+ syncer::SyncNotifierObserver* handler,
+ const syncer::ObjectIdSet& ids) {
if (delegate_.get())
- delegate_->AddObserver(observer);
- bridge_->AddObserver(observer);
-}
-
-void BridgedSyncNotifier::RemoveObserver(
- syncer::SyncNotifierObserver* observer) {
- bridge_->RemoveObserver(observer);
- if (delegate_.get())
- delegate_->RemoveObserver(observer);
+ delegate_->UpdateRegisteredIds(handler, ids);
+ bridge_->UpdateRegisteredIds(handler, ids);
}
void BridgedSyncNotifier::SetUniqueId(const std::string& unique_id) {
@@ -48,12 +42,6 @@ void BridgedSyncNotifier::UpdateCredentials(
delegate_->UpdateCredentials(email, token);
}
-void BridgedSyncNotifier::UpdateEnabledTypes(
- syncer::ModelTypeSet enabled_types) {
- if (delegate_.get())
- delegate_->UpdateEnabledTypes(enabled_types);
-}
-
void BridgedSyncNotifier::SendNotification(
syncer::ModelTypeSet changed_types) {
if (delegate_.get())

Powered by Google App Engine
This is Rietveld 408576698