Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc

Issue 10702074: Refactor sync-specific parts out of SyncNotifier/SyncNotifierObserver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DEPS Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc
diff --git a/chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc b/chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc
index e45ddf3dd77296481bbd9b4ea9e96de00c6187c1..a8ecde64118ebe7e93b05495965934c90ec76ec8 100644
--- a/chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc
+++ b/chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc
@@ -44,12 +44,11 @@ class MockSyncNotifier : public syncer::SyncNotifier {
MockSyncNotifier() {}
virtual ~MockSyncNotifier() {}
- MOCK_METHOD1(AddObserver, void(syncer::SyncNotifierObserver*));
- MOCK_METHOD1(RemoveObserver, void(syncer::SyncNotifierObserver*));
+ MOCK_METHOD2(UpdateRegisteredIds,
+ void(syncer::SyncNotifierObserver*, const syncer::ObjectIdSet&));
MOCK_METHOD1(SetUniqueId, void(const std::string&));
MOCK_METHOD1(SetStateDeprecated, void(const std::string&));
MOCK_METHOD2(UpdateCredentials, void(const std::string&, const std::string&));
- MOCK_METHOD1(UpdateEnabledTypes, void(syncer::ModelTypeSet));
MOCK_METHOD1(SendNotification, void(syncer::ModelTypeSet));
};
@@ -72,18 +71,11 @@ class BridgedSyncNotifierTest : public testing::Test {
BridgedSyncNotifier bridged_notifier_;
};
-TEST_F(BridgedSyncNotifierTest, AddObserver) {
+TEST_F(BridgedSyncNotifierTest, UpdateRegisteredIds) {
syncer::MockSyncNotifierObserver observer;
- EXPECT_CALL(mock_bridge_, AddObserver(&observer));
- EXPECT_CALL(*mock_delegate_, AddObserver(&observer));
- bridged_notifier_.AddObserver(&observer);
-}
-
-TEST_F(BridgedSyncNotifierTest, RemoveObserver) {
- syncer::MockSyncNotifierObserver observer;
- EXPECT_CALL(mock_bridge_, RemoveObserver(&observer));
- EXPECT_CALL(*mock_delegate_, RemoveObserver(&observer));
- bridged_notifier_.RemoveObserver(&observer);
+ EXPECT_CALL(*mock_delegate_, UpdateRegisteredIds(
+ &observer, syncer::ObjectIdSet()));
+ bridged_notifier_.UpdateRegisteredIds(&observer, syncer::ObjectIdSet());
}
TEST_F(BridgedSyncNotifierTest, SetUniqueId) {
@@ -105,13 +97,6 @@ TEST_F(BridgedSyncNotifierTest, UpdateCredentials) {
bridged_notifier_.UpdateCredentials(email, token);
}
-TEST_F(BridgedSyncNotifierTest, UpdateEnabledTypes) {
- syncer::ModelTypeSet enabled_types(syncer::BOOKMARKS, syncer::PREFERENCES);
- EXPECT_CALL(*mock_delegate_,
- UpdateEnabledTypes(HasModelTypes(enabled_types)));
- bridged_notifier_.UpdateEnabledTypes(enabled_types);
-}
-
TEST_F(BridgedSyncNotifierTest, SendNotification) {
syncer::ModelTypeSet changed_types(syncer::SESSIONS, syncer::EXTENSIONS);
EXPECT_CALL(*mock_delegate_, SendNotification(HasModelTypes(changed_types)));

Powered by Google App Engine
This is Rietveld 408576698