Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: sync/notifier/invalidation_util.cc

Issue 10702074: Refactor sync-specific parts out of SyncNotifier/SyncNotifierObserver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Now with tests Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/notifier/invalidation_util.h" 5 #include "sync/notifier/invalidation_util.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "google/cacheinvalidation/include/types.h" 9 #include "google/cacheinvalidation/include/types.h"
10 #include "google/cacheinvalidation/v2/types.pb.h" 10 #include "google/cacheinvalidation/v2/types.pb.h"
(...skipping 18 matching lines...) Expand all
29 return true; 29 return true;
30 } 30 }
31 31
32 bool ObjectIdToRealModelType(const invalidation::ObjectId& object_id, 32 bool ObjectIdToRealModelType(const invalidation::ObjectId& object_id,
33 syncer::ModelType* model_type) { 33 syncer::ModelType* model_type) {
34 return 34 return
35 syncer::NotificationTypeToRealModelType( 35 syncer::NotificationTypeToRealModelType(
36 object_id.name(), model_type); 36 object_id.name(), model_type);
37 } 37 }
38 38
39 ObjectIdSet ModelTypeSetToObjectIdSet(const ModelTypeSet& model_types) {
40 ObjectIdSet ids;
41 for (ModelTypeSet::Iterator it = model_types.First(); it.Good(); it.Inc()) {
42 invalidation::ObjectId model_type_as_id;
43 if (!RealModelTypeToObjectId(it.Get(), &model_type_as_id)) {
44 DLOG(WARNING) << "Invalid model type " << it.Get();
45 continue;
46 }
47 ids.insert(model_type_as_id);
48 }
49 return ids;
50 }
51
52 ModelTypeSet ObjectIdSetToModelTypeSet(const ObjectIdSet& ids) {
53 ModelTypeSet model_types;
54 for (ObjectIdSet::const_iterator it = ids.begin(); it != ids.end(); ++it) {
55 ModelType model_type;
56 if (!ObjectIdToRealModelType(*it, &model_type)) {
57 DLOG(WARNING) << "Invalid object ID " << ObjectIdToString(*it);
58 continue;
59 }
60 model_types.Put(model_type);
61 }
62 return model_types;
63 }
64
39 std::string ObjectIdToString( 65 std::string ObjectIdToString(
40 const invalidation::ObjectId& object_id) { 66 const invalidation::ObjectId& object_id) {
41 std::stringstream ss; 67 std::stringstream ss;
42 ss << "{ "; 68 ss << "{ ";
43 ss << "name: " << object_id.name() << ", "; 69 ss << "name: " << object_id.name() << ", ";
44 ss << "source: " << object_id.source(); 70 ss << "source: " << object_id.source();
45 ss << " }"; 71 ss << " }";
46 return ss.str(); 72 return ss.str();
47 } 73 }
48 74
49 std::string InvalidationToString( 75 std::string InvalidationToString(
50 const invalidation::Invalidation& invalidation) { 76 const invalidation::Invalidation& invalidation) {
51 std::stringstream ss; 77 std::stringstream ss;
52 ss << "{ "; 78 ss << "{ ";
53 ss << "object_id: " << ObjectIdToString(invalidation.object_id()) << ", "; 79 ss << "object_id: " << ObjectIdToString(invalidation.object_id()) << ", ";
54 ss << "version: " << invalidation.version(); 80 ss << "version: " << invalidation.version();
55 ss << " }"; 81 ss << " }";
56 return ss.str(); 82 return ss.str();
57 } 83 }
58 84
59 } // namespace syncer 85 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698