Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: sync/notifier/sync_notifier.h

Issue 10702074: Refactor sync-specific parts out of SyncNotifier/SyncNotifierObserver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review changes Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Interface to the sync notifier, which is an object that receives 5 // Interface to the sync notifier, which is an object that receives
6 // notifications when updates are available for a set of sync types. 6 // notifications when updates are available for a set of sync types.
7 // All the observers are notified when such an event happens. 7 // All the observers are notified when such an event happens.
8 8
9 #ifndef SYNC_NOTIFIER_SYNC_NOTIFIER_H_ 9 #ifndef SYNC_NOTIFIER_SYNC_NOTIFIER_H_
10 #define SYNC_NOTIFIER_SYNC_NOTIFIER_H_ 10 #define SYNC_NOTIFIER_SYNC_NOTIFIER_H_
11 11
12 #include <string> 12 #include <string>
13 13
14 #include "sync/internal_api/public/base/model_type.h" 14 #include "sync/internal_api/public/base/model_type.h"
15 #include "sync/notifier/invalidation_util.h"
15 16
16 namespace syncer { 17 namespace syncer {
17 class SyncNotifierObserver; 18 class SyncNotifierObserver;
18 19
19 class SyncNotifier { 20 class SyncNotifier {
20 public: 21 public:
21 SyncNotifier() {} 22 SyncNotifier() {}
22 virtual ~SyncNotifier() {} 23 virtual ~SyncNotifier() {}
23 24
24 virtual void AddObserver(SyncNotifierObserver* observer) = 0; 25 // Updates the set of ObjectIds associated with a given |handler|. Passing an
25 virtual void RemoveObserver(SyncNotifierObserver* observer) = 0; 26 // empty ObjectIdSet will unregister |handler|. If two different handlers
27 // attempt to register for the same object ID, the first registration wins.
28 virtual void UpdateRegisteredIds(SyncNotifierObserver* handler,
29 const ObjectIdSet& ids) = 0;
26 30
27 // SetUniqueId must be called once, before any call to 31 // SetUniqueId must be called once, before any call to
28 // UpdateCredentials. |unique_id| should be a non-empty globally 32 // UpdateCredentials. |unique_id| should be a non-empty globally
29 // unique string. 33 // unique string.
30 virtual void SetUniqueId(const std::string& unique_id) = 0; 34 virtual void SetUniqueId(const std::string& unique_id) = 0;
31 35
32 // SetState must be called once, before any call to 36 // SetState must be called once, before any call to
33 // UpdateCredentials. |state| may be empty. 37 // UpdateCredentials. |state| may be empty.
34 // Deprecated in favour of InvalidationStateTracker persistence. 38 // Deprecated in favour of InvalidationStateTracker persistence.
35 virtual void SetStateDeprecated(const std::string& state) = 0; 39 virtual void SetStateDeprecated(const std::string& state) = 0;
36 40
37 // The observers won't be notified of any notifications until 41 // The observers won't be notified of any notifications until
38 // UpdateCredentials is called at least once. It can be called more than 42 // UpdateCredentials is called at least once. It can be called more than
39 // once. 43 // once.
40 virtual void UpdateCredentials( 44 virtual void UpdateCredentials(
41 const std::string& email, const std::string& token) = 0; 45 const std::string& email, const std::string& token) = 0;
42 46
43 virtual void UpdateEnabledTypes(ModelTypeSet enabled_types) = 0;
44
45 // This is here only to support the old p2p notification implementation, 47 // This is here only to support the old p2p notification implementation,
46 // which is still used by sync integration tests. 48 // which is still used by sync integration tests.
47 // TODO(akalin): Remove this once we move the integration tests off p2p 49 // TODO(akalin): Remove this once we move the integration tests off p2p
48 // notifications. 50 // notifications.
49 virtual void SendNotification(ModelTypeSet changed_types) = 0; 51 virtual void SendNotification(ModelTypeSet changed_types) = 0;
50 }; 52 };
51 } // namespace syncer 53 } // namespace syncer
52 54
53 #endif // SYNC_NOTIFIER_SYNC_NOTIFIER_H_ 55 #endif // SYNC_NOTIFIER_SYNC_NOTIFIER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698